Skip to content

MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache#22427

Merged
chia7712 merged 3 commits into
apache:trunkfrom
RonGamzu:fix/typo-fixes-reaper-test-and-leader-epoch-cache
Jun 9, 2026
Merged

MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache#22427
chia7712 merged 3 commits into
apache:trunkfrom
RonGamzu:fix/typo-fixes-reaper-test-and-leader-epoch-cache

Conversation

@RonGamzu

@RonGamzu RonGamzu commented May 30, 2026

Copy link
Copy Markdown
Contributor

Fix two minor comment/Javadoc typos found while reading the codebase:

  • CompletableEventReaperTest: the word "amd" (should be "and")
    appeared
    in three identical inline comments across testExpired,
    testCompleted,
    and testCompletedAndExpired.
  • LeaderEpochFileCache: the class-level Javadoc used "instantiater" as
    an agent noun; the correct English form is "instantiator".

No logic or behaviour changes — comments and Javadoc only.

Reviewers: Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com

RonGamzu added 2 commits May 31, 2026 02:48
Three identical test comments in CompletableEventReaperTest contained
the typo 'amd' where 'and' was intended. Fixed all three occurrences
in testExpired, testCompleted, and testCompletedAndExpired.
…adoc

The class-level Javadoc used the non-standard word 'instantiater' as an
agent noun. The correct English form is 'instantiator'.
@github-actions github-actions Bot added the triage PRs from the community label May 30, 2026
@github-actions github-actions Bot added consumer storage Pull requests that target the storage module clients small Small PRs labels May 30, 2026
@RonGamzu RonGamzu changed the title Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache MINOR: Fix minor typos in CompletableEventReaperTest and LeaderEpochFileCache May 30, 2026

@m1a2st m1a2st left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RonGamzu for this patch, could you merge trunk and fix the build error?

@RonGamzu

RonGamzu commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@m1a2st Merged trunk as requested. The branch is now up to date with the latest trunk commits.

@github-actions github-actions Bot removed the triage PRs from the community label Jun 2, 2026

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit c09c9cd into apache:trunk Jun 9, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved clients consumer small Small PRs storage Pull requests that target the storage module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants