Skip to content

[CALCITE-7563] Oracle dialect generates invalid CAST to VARCHAR without precision #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzwqqq wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −0
Open

[CALCITE-7563] Oracle dialect generates invalid CAST to VARCHAR without precision #4973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/java/org/apache/calcite/sql/dialect/OracleSqlDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,13 @@ public OracleSqlDialect(Context context) {
case DOUBLE:
castSpec = "DOUBLE PRECISION";
break;
case VARCHAR:
if (type.getPrecision() == RelDataType.PRECISION_NOT_SPECIFIED) {
final int precision = getTypeSystem().getMaxPrecision(SqlTypeName.VARCHAR);
castSpec = "VARCHAR(" + precision + ")";
break;
}
return super.getCastSpec(type);
default:
return super.getCastSpec(type);
}
Expand Down
15 changes: 15 additions & 0 deletions core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1708,6 +1708,21 @@ private static String toSql(RelNode root, SqlDialect dialect,
.ok(expectedOracle);
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-7563">[CALCITE-7563]
* Oracle dialect generates invalid CAST to VARCHAR without precision</a>. */
@Test void testCastVarcharWithoutPrecisionOracle() {
Copy link
Copy Markdown
Member

@xuzifu666 xuzifu666 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have already tested these sql in Oracle.

Copy link
Copy Markdown
Contributor Author

@zzwqqq zzwqqq May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I have tested the SQL against a real Oracle instance and here https://onecompiler.com/oracle/44qmsuytf

final String query = "select cast(\"store_id\" as VARCHAR)\n"
+ " from \"expense_fact\"";
final String expected = "SELECT CAST(\"store_id\" AS VARCHAR(4000))\n"
+ "FROM \"foodmart\".\"expense_fact\"";
final String expectedModifiedTypeSystem = "SELECT CAST(\"store_id\" AS VARCHAR(512))\n"
+ "FROM \"foodmart\".\"expense_fact\"";
sql(query)
.withOracle().ok(expected)
.withOracleModifiedTypeSystem().ok(expectedModifiedTypeSystem);
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-1174">[CALCITE-1174]
* When generating SQL, translate SUM0(x) to COALESCE(SUM(x), 0)</a>. */
Expand Down
Loading