[CALCITE-7563] Oracle dialect generates invalid CAST to VARCHAR without precision#4973
Open
zzwqqq wants to merge 1 commit into
Open
[CALCITE-7563] Oracle dialect generates invalid CAST to VARCHAR without precision#4973zzwqqq wants to merge 1 commit into
zzwqqq wants to merge 1 commit into
Conversation
|
xuzifu666
approved these changes
May 28, 2026
| /** Test case for | ||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-7563">[CALCITE-7563] | ||
| * Oracle dialect generates invalid CAST to VARCHAR without precision</a>. */ | ||
| @Test void testCastVarcharWithoutPrecisionOracle() { |
Member
There was a problem hiding this comment.
I assume you have already tested these sql in Oracle.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. I have tested the SQL against a real Oracle instance and here https://onecompiler.com/oracle/44qmsuytf
Member
|
After version 1.42 is released, I will merge this pr if there are no other comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7563
Changes Proposed
Oracle treats VARCHAR as synonymous with VARCHAR2, and VARCHAR2 requires a size. RelToSqlConverter with OracleSqlDialect could generate invalid SQL such as CAST(expr AS VARCHAR) when the target VARCHAR type had unspecified precision.
Use the Oracle type system's max precision for VARCHAR in this case, and add a regression test.