Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/opencode/src/cli/cmd/tui/attach.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { tui } from "./app"
import { win32DisableProcessedInput, win32InstallCtrlCGuard } from "./win32"
import { TuiConfig } from "@/config/tui"
import { Instance } from "@/project/instance"
import { AppRuntime } from "@/effect/app-runtime"
import { existsSync } from "fs"

export const AttachCommand = cmd({
Expand Down Expand Up @@ -68,7 +69,7 @@ export const AttachCommand = cmd({
})()
const config = await Instance.provide({
directory: directory && existsSync(directory) ? directory : process.cwd(),
fn: () => TuiConfig.get(),
fn: () => AppRuntime.runPromise(TuiConfig.Service.use((svc) => svc.get())),
})
await tui({
url: args.url,
Expand Down
12 changes: 9 additions & 3 deletions packages/opencode/src/cli/cmd/tui/plugin/runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { fileURLToPath } from "url"

import { Config } from "@/config/config"
import { TuiConfig } from "@/config/tui"
import { AppRuntime } from "@/effect/app-runtime"
import { Log } from "@/util/log"
import { errorData, errorMessage } from "@/util/error"
import { isRecord } from "@/util/record"
Expand Down Expand Up @@ -794,7 +795,10 @@ async function addPluginBySpec(state: RuntimeState | undefined, raw: string) {

const ready = await Instance.provide({
directory: state.directory,
fn: () => resolveExternalPlugins([cfg], () => TuiConfig.waitForDependencies()),
fn: () =>
resolveExternalPlugins([cfg], () =>
AppRuntime.runPromise(TuiConfig.Service.use((svc) => svc.waitForDependencies())),
),
}).catch((error) => {
fail("failed to add tui plugin", { path: next, error })
return [] as PluginLoad[]
Expand Down Expand Up @@ -991,7 +995,7 @@ export namespace TuiPluginRuntime {
await Instance.provide({
directory: cwd,
fn: async () => {
const config = await TuiConfig.get()
const config = await AppRuntime.runPromise(TuiConfig.Service.use((svc) => svc.get()))
const records = Flag.OPENCODE_PURE ? [] : (config.plugin_origins ?? [])
if (Flag.OPENCODE_PURE && config.plugin_origins?.length) {
log.info("skipping external tui plugins in pure mode", { count: config.plugin_origins.length })
Expand All @@ -1011,7 +1015,9 @@ export namespace TuiPluginRuntime {
})
}

const ready = await resolveExternalPlugins(records, () => TuiConfig.waitForDependencies())
const ready = await resolveExternalPlugins(records, () =>
AppRuntime.runPromise(TuiConfig.Service.use((svc) => svc.waitForDependencies())),
)
await addExternalPluginEntries(next, ready)

applyInitialPluginEnabledState(next, config)
Expand Down
3 changes: 2 additions & 1 deletion packages/opencode/src/cli/cmd/tui/thread.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import type { EventSource } from "./context/sdk"
import { win32DisableProcessedInput, win32InstallCtrlCGuard } from "./win32"
import { TuiConfig } from "@/config/tui"
import { Instance } from "@/project/instance"
import { AppRuntime } from "@/effect/app-runtime"
import { writeHeapSnapshot } from "v8"

declare global {
Expand Down Expand Up @@ -179,7 +180,7 @@ export const TuiThreadCommand = cmd({
const prompt = await input(args.prompt)
const config = await Instance.provide({
directory: cwd,
fn: () => TuiConfig.get(),
fn: () => AppRuntime.runPromise(TuiConfig.Service.use((svc) => svc.get())),
})

const network = await resolveNetworkOptions(args)
Expand Down
11 changes: 0 additions & 11 deletions packages/opencode/src/config/tui.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { isRecord } from "@/util/record"
import { Global } from "@/global"
import { Filesystem } from "@/util/filesystem"
import { InstanceState } from "@/effect/instance-state"
import { makeRuntime } from "@/effect/run-service"
import { AppFileSystem } from "@/filesystem"

export namespace TuiConfig {
Expand Down Expand Up @@ -170,16 +169,6 @@ export namespace TuiConfig {

export const defaultLayer = layer.pipe(Layer.provide(Config.defaultLayer))

const { runPromise } = makeRuntime(Service, defaultLayer)

export async function get() {
return runPromise((svc) => svc.get())
}

export async function waitForDependencies() {
await runPromise((svc) => svc.waitForDependencies())
}

async function loadFile(filepath: string): Promise<Info> {
const text = await ConfigPaths.readFile(filepath)
if (!text) return {}
Expand Down
2 changes: 2 additions & 0 deletions packages/opencode/src/effect/app-runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ import { Pty } from "@/pty"
import { Installation } from "@/installation"
import { ShareNext } from "@/share/share-next"
import { SessionShare } from "@/share/session"
import { TuiConfig } from "@/config/tui"

export const AppLayer = Layer.mergeAll(
Observability.layer,
Expand Down Expand Up @@ -95,6 +96,7 @@ export const AppLayer = Layer.mergeAll(
Installation.defaultLayer,
ShareNext.defaultLayer,
SessionShare.defaultLayer,
TuiConfig.defaultLayer,
)

const rt = ManagedRuntime.make(AppLayer, { memoMap })
Expand Down
38 changes: 20 additions & 18 deletions packages/opencode/test/cli/tui/plugin-add.test.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { expect, spyOn, test } from "bun:test"
import fs from "fs/promises"
import path from "path"
import { Effect } from "effect"
import { pathToFileURL } from "url"
import { tmpdir } from "../../fixture/fixture"
import { createTuiPluginApi } from "../../fixture/tui-plugin"
import { TuiConfig } from "../../../src/config/tui"
import { mockTuiService } from "../../fixture/tui-runtime"

const { TuiPluginRuntime } = await import("../../../src/cli/cmd/tui/plugin/runtime")

Expand All @@ -31,11 +32,10 @@ test("adds tui plugin at runtime from spec", async () => {
})

process.env.OPENCODE_PLUGIN_META_FILE = path.join(tmp.path, "plugin-meta.json")
const get = spyOn(TuiConfig, "get").mockResolvedValue({
const restore = mockTuiService({
plugin: [],
plugin_origins: undefined,
})
const wait = spyOn(TuiConfig, "waitForDependencies").mockResolvedValue()
const cwd = spyOn(process, "cwd").mockImplementation(() => tmp.path)

try {
Expand All @@ -54,8 +54,7 @@ test("adds tui plugin at runtime from spec", async () => {
} finally {
await TuiPluginRuntime.dispose()
cwd.mockRestore()
get.mockRestore()
wait.mockRestore()
restore()
delete process.env.OPENCODE_PLUGIN_META_FILE
}
})
Expand All @@ -72,36 +71,39 @@ test("retries runtime add for file plugins after dependency wait", async () => {
})

process.env.OPENCODE_PLUGIN_META_FILE = path.join(tmp.path, "plugin-meta.json")
const get = spyOn(TuiConfig, "get").mockResolvedValue({
plugin: [],
plugin_origins: undefined,
})
const wait = spyOn(TuiConfig, "waitForDependencies").mockImplementation(async () => {
await Bun.write(
path.join(tmp.extra.mod, "index.ts"),
`export default {
const restore = mockTuiService(
{
plugin: [],
plugin_origins: undefined,
},
{
wait: () =>
Effect.promise(async () => {
await Bun.write(
path.join(tmp.extra.mod, "index.ts"),
`export default {
id: "demo.add.retry",
tui: async () => {
await Bun.write(${JSON.stringify(tmp.extra.marker)}, "called")
},
}
`,
)
})
)
}),
},
)
const cwd = spyOn(process, "cwd").mockImplementation(() => tmp.path)

try {
await TuiPluginRuntime.init(createTuiPluginApi())

await expect(TuiPluginRuntime.addPlugin(tmp.extra.spec)).resolves.toBe(true)
await expect(fs.readFile(tmp.extra.marker, "utf8")).resolves.toBe("called")
expect(wait).toHaveBeenCalledTimes(1)
expect(TuiPluginRuntime.list().find((item) => item.id === "demo.add.retry")?.active).toBe(true)
} finally {
await TuiPluginRuntime.dispose()
cwd.mockRestore()
get.mockRestore()
wait.mockRestore()
restore()
delete process.env.OPENCODE_PLUGIN_META_FILE
}
})
9 changes: 4 additions & 5 deletions packages/opencode/test/cli/tui/plugin-install.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { pathToFileURL } from "url"
import { tmpdir } from "../../fixture/fixture"
import { createTuiPluginApi } from "../../fixture/tui-plugin"
import { TuiConfig } from "../../../src/config/tui"
import { mockTuiService } from "../../fixture/tui-runtime"

const { TuiPluginRuntime } = await import("../../../src/cli/cmd/tui/plugin/runtime")

Expand Down Expand Up @@ -50,12 +51,11 @@ test("installs plugin without loading it", async () => {
})

process.env.OPENCODE_PLUGIN_META_FILE = path.join(tmp.path, "plugin-meta.json")
const cfg: Awaited<ReturnType<typeof TuiConfig.get>> = {
const cfg: TuiConfig.Info = {
plugin: [],
plugin_origins: undefined,
}
const get = spyOn(TuiConfig, "get").mockImplementation(async () => cfg)
const wait = spyOn(TuiConfig, "waitForDependencies").mockResolvedValue()
const restore = mockTuiService(cfg)
const cwd = spyOn(process, "cwd").mockImplementation(() => tmp.path)
const api = createTuiPluginApi({
state: {
Expand All @@ -82,8 +82,7 @@ test("installs plugin without loading it", async () => {
} finally {
await TuiPluginRuntime.dispose()
cwd.mockRestore()
get.mockRestore()
wait.mockRestore()
restore()
delete process.env.OPENCODE_PLUGIN_META_FILE
}
})
1 change: 0 additions & 1 deletion packages/opencode/test/cli/tui/plugin-lifecycle.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { pathToFileURL } from "url"
import { tmpdir } from "../../fixture/fixture"
import { createTuiPluginApi } from "../../fixture/tui-plugin"
import { mockTuiRuntime } from "../../fixture/tui-runtime"
import { TuiConfig } from "../../../src/config/tui"

const { TuiPluginRuntime } = await import("../../../src/cli/cmd/tui/plugin/runtime")

Expand Down
Loading
Loading