refactor: remove makeRuntime from TuiConfig#22517
Closed
kitlangton wants to merge 1 commit intodevfrom
Closed
Conversation
kitlangton
force-pushed
the
kit/tui-facade-cleanup
branch
from
812011c to
fca7e79
Compare
Delete get() and waitForDependencies() facade functions from config/tui.ts. Add TuiConfig.defaultLayer to AppLayer so the service is available via AppRuntime. Migrate all callers (attach.ts, thread.ts, plugin/runtime.ts) to AppRuntime.runPromise(TuiConfig.Service.use(...)). Migrate tui.test.ts (~28 calls) to the same pattern. Rework test fixture: replace spyOn(TuiConfig, 'get') with mockTuiService helper that mocks TuiConfig.Service.use at the Effect level. Update all 9 test files that spied on the old facades.
kitlangton
force-pushed
the
kit/tui-facade-cleanup
branch
from
fca7e79 to
a8d6379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TuiConfig.defaultLayertoAppLayersoTuiConfig.Serviceis available via the shared runtimemakeRuntimeinconfig/tui.tswith dynamicimport()ofAppRuntime(avoids circular dep)get,waitForDependencies) intact — they're spied on bytest/fixture/tui-runtime.tsmockTuiRuntimehelper used in plugin-lifecycle testsPart of the residual
makeRuntimecleanup tracked inspecs/effect/facades.md.