Skip to content

projects: adrd8012_01z: Change name of AD_GMSL2ETH_SL project (currently ADRD8012_01z)#2020

Open
alin724 wants to merge 2 commits into
mainfrom
update_adrd8012_01z
Open

projects: adrd8012_01z: Change name of AD_GMSL2ETH_SL project (currently ADRD8012_01z)#2020
alin724 wants to merge 2 commits into
mainfrom
update_adrd8012_01z

Conversation

@alin724
Copy link
Copy Markdown
Contributor

@alin724 alin724 commented Mar 4, 2026 •
edited
Loading

PR Description

Change name of AD_GMSL2ETH_SL project (currently ADRD8012_01z)

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@alin724
docs: adrd8012_01z: Change name of AD_GMSL2ETH_SL board (currently AD…
ed47d88 
…RD8012_01z)

Signed-off-by: alin724 <alin-tudor.sferle@analog.com>
@alin724 alin724 force-pushed the update_adrd8012_01z branch from a484635 to 8c53cb3 Compare March 4, 2026 12:38
@alin724 alin724 changed the title projects: ad_gmsl2eth_sl: Update project name to ADRD8012-01z (current board name) projects: adrd8012_01z: Change name of AD_GMSL2ETH_SL project (currently ADRD8012_01z) Mar 4, 2026
@alin724 alin724 force-pushed the update_adrd8012_01z branch from 8c53cb3 to 23f94d5 Compare March 4, 2026 12:41
@alin724 alin724 requested a review from IstvanZsSzekely March 5, 2026 12:48
IstvanZsSzekely
IstvanZsSzekely requested changes Mar 9, 2026
View reviewed changes
Comment thread projects/adrd8012_01z/common/adrd8012_01z_bd.tcl
@alin724
projects: adrd8012_01z: Change name of AD_GMSL2ETH_SL project (curren…
3327d35 
…tly ADRD8012_01z)

Change the name of AD_GMSL2ETH_SL HDL project + fix the Corundum NIC reset mismatch

Signed-off-by: alin724 <alin-tudor.sferle@analog.com>
@alin724 alin724 force-pushed the update_adrd8012_01z branch from 23f94d5 to 3327d35 Compare April 27, 2026 15:25
@alin724 alin724 requested a review from IstvanZsSzekely April 28, 2026 07:30
IstvanZsSzekely
IstvanZsSzekely requested changes Apr 29, 2026
View reviewed changes
Comment thread projects/adrd8012_01z/common/adrd8012_01z_bd.tcl
ad_connect corundum_hierarchy/clk_corundum $sys_dma_clk
ad_connect corundum_rstgen/slowest_sync_clk $sys_dma_clk
ad_connect corundum_rstgen/ext_reset_in $sys_dma_resetn
ad_ip_parameter corundum_rstgen CONFIG.C_AUX_RESET_HIGH {0}
Copy link
Copy Markdown
Contributor

@IstvanZsSzekely IstvanZsSzekely Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the latest changes, the block design, the implemented design and the discussion on the reset signals.
In the implemented design the auxiliary reset signal is hardwired to ground, the auxiliary reset's polarity is set to active low, which in theory asserts the reset and keeps the Corundum system in reset. In the Corundum creation script, the auxiliary reset's polarity is active high.
Was this design tested on hardware? I'm curious to see how this configuration behaves. As I recall, there was a similar issue with reset in a different design that might have had the same thing, where the reset was kept asserted.
This change is redundant. I recommend keeping the auxiliary reset polarity high and let Vivado hardwire it to the ground, as it won't affect the reset IP's functionality.

@alin724 alin724 requested a review from IstvanZsSzekely May 6, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

@IstvanZsSzekely IstvanZsSzekely Awaiting requested review from IstvanZsSzekely

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alin724 @IstvanZsSzekely