Skip to content

fix: refines number type check #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
li-jia-nan merged 4 commits into from
Apr 16, 2026
+5 −4
Merged

fix: refines number type check #2928

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2ddba3
fix: refines number type check
li-jia-nan Apr 13, 2026
c107f68
fix: refines number type check
li-jia-nan Apr 13, 2026
3a15f93
test: update test case
li-jia-nan Apr 13, 2026
597c0de
test: update test case
li-jia-nan Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/hooks/src/useCountDown/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import dayjs from 'dayjs';
import { useEffect, useMemo, useState } from 'react';
import useLatest from '../useLatest';
import { isNumber } from '../utils/index';
import { isNumber } from '../utils';

export type TDate = dayjs.ConfigType;

Expand Down
2 changes: 1 addition & 1 deletion packages/hooks/src/utils/__tests__/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { describe, expect, test } from 'vitest';
import { isBoolean, isFunction, isNumber, isObject, isString, isUndef } from '../index';
import { isBoolean, isFunction, isNumber, isObject, isString, isUndef } from '../';
Comment thread
li-jia-nan marked this conversation as resolved.

describe('shared utils methods', () => {
test('isBoolean', () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/hooks/src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ export const isFunction = (value: unknown): value is (...args: any) => any =>
typeof value === 'function';
export const isString = (value: unknown): value is string => typeof value === 'string';
export const isBoolean = (value: unknown): value is boolean => typeof value === 'boolean';
export const isNumber = (value: unknown): value is number => typeof value === 'number';
export const isNumber = (value: unknown): value is number =>
typeof value === 'number' && !Number.isNaN(value);
export const isUndef = (value: unknown): value is undefined => typeof value === 'undefined';
Loading