fix: refines number type check#2928
Merged
li-jia-nan merged 4 commits intomasterfrom Apr 16, 2026
Merged
Conversation
commit: |
There was a problem hiding this comment.
Pull request overview
Refines the shared isNumber utility to treat NaN as non-number (for validation use cases across hooks) and aligns a couple of imports to use the utils barrel export.
Changes:
- Update
isNumberto returnfalseforNaN. - Switch imports to
../utils/../barrel paths in a test and a hook.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/hooks/src/utils/index.ts | Refines isNumber to exclude NaN. |
| packages/hooks/src/utils/tests/index.spec.ts | Adjusts utils test import path (but still asserts NaN is a number). |
| packages/hooks/src/useCountDown/index.ts | Updates isNumber import to use the utils barrel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge