fix(nostr): reject reserved indices and cross-app option misuse - #76
Merged
Merged
Conversation
- Error (not warn) on reserved identity 0' and index 0' per BIP-85 nostr, including the implicit --index default of 0 - Error when --identity is passed to a non-nostr application (matches --to) - Error when --number is passed to nostr (matches wif|xprv) Co-authored-by: Cursor <cursoragent@cursor.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #70 (base branch
pr-70-nostris a copy of its head). Merge this intopr-70-nostr, then mergepr-70-nostrtomain— GitHub will mark #70 merged automatically once its commits reach main.0'and index0'now hard-error instead of warning (BIP-85 reserves both for future key management; usable keys start at 1'). The global--indexdefault of 0 therefore also errors for nostr, so the reserved proof key can never be emitted by accident.--identitywith any non-nostr application now raises, matching the--toprecedent.--numberwith nostr now raises, matching wif|xprv.All 362 tests pass; the three merged-spec vectors still verify.
Made with Cursor