release: 4.0.0 (nostr) - #78
Merged
Merged
Conversation
- Error (not warn) on reserved identity 0' and index 0' per BIP-85 nostr, including the implicit --index default of 0 - Error when --identity is passed to a non-nostr application (matches --to) - Error when --number is passed to nostr (matches wif|xprv) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
pr-70-nostr(its stacked base), but feat: Add Nostr app #70 was then merged to main directly from the fork, so the fix never reached main — without this, main still emits reserved-index keys with only a warning.pyproject.tomlandsrc/bipsea/util.py(make check-version-syncpasses).All 362 tests pass;
bipsea --versionreports 4.0.0; the three merged BIP-85 nostr vectors verify.Made with Cursor