WIP: Support python 3.14 - #7074
Conversation
| - alembic~=1.8 | ||
| - archive-path~=0.4.2 | ||
| - asyncssh~=2.19.0 | ||
| - asyncssh~=2.21.0 |
There was a problem hiding this comment.
This bump is needed as 2.20.0 version had some Python 3.14 fixes
There was a problem hiding this comment.
| - archive-path~=0.4.2 | ||
| - asyncssh~=2.19.0 | ||
| - asyncssh~=2.21.0 | ||
| - circus~=0.19.0 |
There was a problem hiding this comment.
Opened a PR with tests for 3.14
circus-tent/circus#1233
| - asyncssh~=2.21.0 | ||
| - circus~=0.19.0 | ||
| - click-spinner~=0.1.8 | ||
| - click<8.3,>=8.1.0 |
There was a problem hiding this comment.
btw: get-annotations dependency can be dropped once we drop support for Python 3.9
| - jinja2~=3.0 | ||
| - kiwipy[rmq]~=0.8.4 | ||
| - kiwipy[rmq]>=0.8.4 | ||
| - importlib-metadata~=6.0 |
There was a problem hiding this comment.
btw: importlib-metadata can be dropped once we drop 3.9 in favour of stdlib importlib.metadata, see comment in: aiida/plugins/entry_point.py
| @@ -38,3 +38,4 @@ dependencies: | |||
| - upf_to_json~=0.9.2 | |||
There was a problem hiding this comment.
tabulate seems to work with 3.14
astanin/python-tabulate#372
| @@ -38,3 +38,4 @@ dependencies: | |||
| - upf_to_json~=0.9.2 | |||
| - wrapt~=1.11 | |||
There was a problem hiding this comment.
Wrapt just had a 2.0 release: https://wrapt.readthedocs.io/en/latest/changes.html#version-2-0-0
Looking at the changelog it seems that it should be safe to upgrade (we're only using wrapt.decorator).
We could also choose to support both 1.x and 2.x, as there might be aiida plugins that depend on wrapt as well.
Possibly the biggest reason to update is that the package is now typed. :-)
c2c29f4 to
ac0041a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7074 +/- ##
===========================================
- Coverage 79.60% 29.98% -49.61%
===========================================
Files 565 565
Lines 43577 43551 -26
===========================================
- Hits 34684 13055 -21629
- Misses 8893 30496 +21603 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superceded by #7240 |
1 participant
WIP but seems to work! The biggest obstackle is the change in behaviour in
asyncio.get_event_loopwhich now throws aRuntimeErrorif there's no loop. This requires fixes in both aiida-core and plumpy. The correspondingplumpyPR is aiidateam/plumpy#329.Otherwise things seems to just work.