Skip to content

Tests: omit needless requires_rmq for tests that don't need RabbitMQ - #7076

Merged
danielhollas merged 3 commits into
aiidateam:mainfrom
danielhollas:tests/omit-needless-requires-rmq
Nov 10, 2025
Merged

Tests: omit needless requires_rmq for tests that don't need RabbitMQ#7076
danielhollas merged 3 commits into
aiidateam:mainfrom
danielhollas:tests/omit-needless-requires-rmq

Conversation

@danielhollas

@danielhollas danielhollas commented Oct 31, 2025

Copy link
Copy Markdown
Collaborator

I noticed that there are a lot of tests marked with requires_rmq pytest marker even though they run perfectly fine without RabbitMQ. That probably comes from a time before the presto command and before there was an option to have a profile without a broker.

Split from #7074

Test plan

Make sure that the tests-presto CI job passes.

@danielhollas
danielhollas requested a review from GeigerJ2 October 31, 2025 13:45
@codecov

codecov Bot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.60%. Comparing base (fc00f5d) to head (0713496).
⚠️ Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7076      +/-   ##
==========================================
+ Coverage   77.59%   77.60%   +0.01%     
==========================================
  Files         566      566              
  Lines       43498    43498              
==========================================
+ Hits        33750    33754       +4     
+ Misses       9748     9744       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GeigerJ2 GeigerJ2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot, @danielhollas!

@danielhollas
danielhollas merged commit 586f372 into aiidateam:main Nov 10, 2025
15 checks passed
danielhollas added a commit to danielhollas/aiida-core that referenced this pull request Nov 16, 2025
danielhollas added a commit to danielhollas/aiida-core that referenced this pull request Nov 17, 2025
danielhollas added a commit that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants