fix: use browser utilities with default dialog handling - #31
Merged
Conversation
Update the native Puppeteer runtime to 2.0.2 so unhandled JavaScript dialogs do not stall course grading. Both browser model answers pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Update @exercode/problem-utils-browser to the published 2.0.2 runtime. Preset pages dismiss alert, confirm and prompt dialogs unless the grader registers its own handler, preventing unhandled dialogs from stalling grading. Core remains pinned to 4.2.1, matching the browser package.
bun run testpassed both browser model answers against the installed public package. The published runtime matches the shared package's fully verified artifact. The lockfile retains registry-independent tarball resolution, and installation uses the isolated linker with dependency lifecycle scripts disabled. Review-booster completed with all seven reviewers and no defect findings; merge readiness passed on f8f6286.