Use trakt.show_id for episodes

[simonc56]

requires :

• [python-pytrakt] Add show_id attribute to TVEpisode found from search moogar0880/PyTrakt#208
• add show_id to TVEpisode glensc/python-pytrakt#6 (v3.4.9)
• Bump pytrakt from 3.4.8 to 3.4.9 #1143

Uses the newly added show_id attribute of trakt TVEpisode instead of TVShow id found from Plex show guid.
Usefull when a Plex show is split in many Trakt shows.

closes #1111

[glensc]

There are more places where .show is assigned:

$ git grep -F '.show ='
plextraktsync/commands/watch.py:            m.show = ms
plextraktsync/pytrakt_extensions.py:        self.show = show

[glensc]

dependency of moogar0880/PyTrakt#208 has been solved in 68ced57

[glensc]

And the show getter/setter added to Media class via #1119 is then also not needed. and once that is removed the media.mf becomes also unused

[glensc]

Since lazyepisodes is gone, you probably need to add show_id to the block added in:

• https://github.com/moogar0880/PyTrakt/pull/176/files

[glensc]

perhaps something like

diff --git a/trakt/tv.py b/trakt/tv.py
index e41bf4f..90c7c60 100644
--- a/trakt/tv.py
+++ b/trakt/tv.py
@@ -439,7 +439,7 @@ class TVShow(object):
                 # Prepare episodes
                 episodes = []
                 for ep in season.pop('episodes', []):
-                    episode = TVEpisode(show=self.title, **ep)
+                    episode = TVEpisode(show=self.title, show_id=self.trakt, **ep)
                     episodes.append(episode)
                 season['episodes'] = episodes
 

[glensc]

remove this. if you want to mute the warning, use log filtering:

• Refactor: Add support filtering out unwanted log messages #1102

[simonc56]

Why does it warn the user about this retry ? What is he supposed to do with this info ?

[glensc]

I don't recall anymore why it happened, because data in trakt.tv wrong? or wrong agent?

[simonc56]

I'm not asking why it happen. I'm asking why should we warn user about it.
It happen when show order is different between trakt and plex. But the script handles it perfectly now, so the warning has become useless IMHO.

[glensc]

but i am asking why it happens. i recall it was just temporary workaround until real problem is solved.

this fallback is slow (when doing sync) and should be dropped eventually.

[glensc]

and i think it's also unsafe, this code path gets hit when no match is found, but if trakt/plex have different ordering and match is found you would be recording "watched" state to wrong episode.

i don't remember all details anymore.

[simonc56]

if trakt/plex have different ordering and match is found you would be recording "watched" state to wrong episode

No, as I said, the script handles different ordering perfectly now, it cannot match a wrong episode anymore. So this warning is useless on user side, that's why i moved it to debug level.

[simonc56]

this fallback is slow (when doing sync) and should be dropped eventually.

It is needed sometimes. Eg. when a show is split in many shows in trakt.

[glensc]

ok. keep it as debug then

[glensc]

the .show is usually needed if you pass the episode object around, to resolve some details (like that Lookup class), need a related show object. maybe could refactor this out by adding to PlexLibraryItem the show property. this will likely simplify tons of code.

[simonc56]

the .show is usually needed if you pass the episode object around

Can you show me where .show is needed ?

[glensc]

Can you show me where .show is needed ?

I'm not going to answer this 3rd time. remove it and see yourself what breaks!

[glensc]

Does this also improve performance? memory usage? overall runtime? api calls?