Skip to content

Refactor: Add show property to PlexLibraryItem#1136

Draft
glensc wants to merge 6 commits into
Taxel:mainfrom
glensc:PlexLibraryItem-plex
Draft

Refactor: Add show property to PlexLibraryItem#1136
glensc wants to merge 6 commits into
Taxel:mainfrom
glensc:PlexLibraryItem-plex

Conversation

@glensc

@glensc glensc commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

It's only valid if the type is episode.

refs:

@glensc glensc self-assigned this Oct 24, 2022
@glensc glensc force-pushed the PlexLibraryItem-plex branch from 2ae685f to ddbb53d Compare October 24, 2022 23:40
@glensc

glensc commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator Author

Actually, need Trakt object for Lookup class:

lookup = TraktLookup(self.trakt)

I might have analyzed wrong that plex show object was needed.

@simonc56

Copy link
Copy Markdown
Collaborator

Where is this show property needed ?

@glensc

glensc commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator Author

Where is this show property needed ?

I already answered, it's need for episode object to create TraktLookup object.

@glensc

glensc commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator Author

Also, seems PlexApi Episode object has show() method:

altho it's not efficient one, it's always fetching from plex server.

@glensc glensc force-pushed the PlexLibraryItem-plex branch 2 times, most recently from 465da67 to f007aed Compare January 5, 2024 19:00
@glensc glensc force-pushed the PlexLibraryItem-plex branch from f007aed to 7e02987 Compare January 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants