Skip to content

split MemoryNoteModel into specialized subclasses #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jamiras merged 3 commits into from
Oct 4, 2026
Merged

split MemoryNoteModel into specialized subclasses #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ae1e62
split MemoryNoteModel into specialized subclasses
Jamiras Sep 21, 2026
b404bcf
address analysis warning
Jamiras Sep 28, 2026
42fc37d
also mark mid byte of large note as indirect
Jamiras Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/devkit/RADevKit.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@
<ClCompile Include="data\models\MemoryNoteModel.cpp" />
<ClCompile Include="data\models\MemoryNotesModel.cpp" />
<ClCompile Include="data\models\MemoryRegionsModel.cpp" />
<ClCompile Include="data\models\PointerMemoryNoteModel.cpp" />
<ClCompile Include="data\models\RichPresenceModel.cpp" />
<ClCompile Include="data\models\StructuredMemoryNoteModel.cpp" />
<ClCompile Include="data\models\ValueMemoryNoteModel.cpp" />
<ClCompile Include="data\Requirement.cpp" />
<ClCompile Include="data\util\AchievementLogicSerializer.cpp" />
<ClCompile Include="data\util\IndirectNoteResolver.cpp" />
Expand Down Expand Up @@ -113,13 +116,17 @@
<ClInclude Include="data\models\AchievementModel.hh" />
<ClInclude Include="data\models\AchievementSetModel.hh" />
<ClInclude Include="data\models\AssetModelBase.hh" />
<ClInclude Include="data\models\AuthoredMemoryNoteModel.hh" />
<ClInclude Include="data\models\GameAssets.hh" />
<ClInclude Include="data\models\LeaderboardModel.hh" />
<ClInclude Include="data\models\LocalBadgesModel.hh" />
<ClInclude Include="data\models\MemoryNoteModel.hh" />
<ClInclude Include="data\models\MemoryNotesModel.hh" />
<ClInclude Include="data\models\MemoryRegionsModel.hh" />
<ClInclude Include="data\models\PointerMemoryNoteModel.hh" />
<ClInclude Include="data\models\RichPresenceModel.hh" />
<ClInclude Include="data\models\StructuredMemoryNoteModel.hh" />
<ClInclude Include="data\models\ValueMemoryNoteModel.hh" />
<ClInclude Include="data\NotifyTargetSet.hh" />
<ClInclude Include="data\Requirement.hh" />
<ClInclude Include="data\util\AchievementLogicSerializer.hh" />
Expand Down
21 changes: 21 additions & 0 deletions src/devkit/RADevKit.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,18 @@
<ClInclude Include="data\Requirement.hh">
<Filter>data</Filter>
</ClInclude>
<ClInclude Include="data\models\ValueMemoryNoteModel.hh">
<Filter>data\models</Filter>
</ClInclude>
<ClInclude Include="data\models\AuthoredMemoryNoteModel.hh">
<Filter>data\models</Filter>
</ClInclude>
<ClInclude Include="data\models\PointerMemoryNoteModel.hh">
<Filter>data\models</Filter>
</ClInclude>
<ClInclude Include="data\models\StructuredMemoryNoteModel.hh">
<Filter>data\models</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
<ClCompile Include="util\GSL.cpp">
Expand Down Expand Up @@ -335,5 +347,14 @@
<ClCompile Include="data\Requirement.cpp">
<Filter>data</Filter>
</ClCompile>
<ClCompile Include="data\models\ValueMemoryNoteModel.cpp">
<Filter>data\models</Filter>
</ClCompile>
<ClCompile Include="data\models\PointerMemoryNoteModel.cpp">
<Filter>data\models</Filter>
</ClCompile>
<ClCompile Include="data\models\StructuredMemoryNoteModel.cpp">
<Filter>data\models</Filter>
</ClCompile>
</ItemGroup>
</Project>
38 changes: 38 additions & 0 deletions src/devkit/data/models/AuthoredMemoryNoteModel.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#ifndef RA_DATA_MODELS_AUTHOREDMEMORYNOTEMODEL_H
#define RA_DATA_MODELS_AUTHOREDMEMORYNOTEMODEL_H
#pragma once

#include "MemoryNoteModel.hh"

namespace ra {
namespace data {
namespace models {

class AuthoredMemoryNoteModel
{
public:
/// <summary>
/// Gets the author of the note.
/// </summary>
const std::string& GetAuthor() const noexcept { return m_sAuthor; }

/// <summary>
/// Sets the author of the note.
/// </summary>
void SetAuthor(const std::string& sAuthor) { m_sAuthor = sAuthor; }

protected:
AuthoredMemoryNoteModel(const std::wstring& sNote)
: m_sNote(sNote)
{
}

std::wstring m_sNote;
std::string m_sAuthor;
};

} // namespace models
} // namespace data
} // namespace ra

#endif RA_DATA_MODELS_AUTHOREDMEMORYNOTEMODEL_H
Loading
Loading