Repository navigation
split MemoryNoteModel into specialized subclasses - #1357
Merged
Jamiras merged 3 commits intoOct 4, 2026
Merged
Conversation
Jamiras
force-pushed
the
feature/memory_note_hier
branch
from
October 3, 2026 14:32
3e2d78b to
42fc37d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryNoteModelis now a base class forPointerMemoryNoteModelandValueMemoryNoteModel. A third subclass will be added for Array notes in a future PR.Also makes several under-the-hood changes to improve performance when traversing pointer notes - most notably avoiding redundant traversals to get separate pieces of data.