Skip to content

[ASan] Exclude .hipFatBinSegment and .nvFatBinSegment from instrument… #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geomin12 wants to merge 1 commit into
base: amd-staging
Choose a base branch
from
+10 −0
Open

[ASan] Exclude .hipFatBinSegment and .nvFatBinSegment from instrument… #2544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2193,6 +2193,16 @@ bool ModuleAddressSanitizer::shouldInstrumentGlobal(GlobalVariable *G) const {
return false;
}

// Do not instrument HIP/CUDA fat binary wrapper sections. These sections
// contain tightly-packed arrays of __CudaFatBinaryWrapper structs (24
// bytes each). The HIP runtime and tools like rocm-kpack walk these
// sections assuming a contiguous 24-byte stride. Adding redzones would
// break this layout assumption.
// See https://github.com/ROCm/TheRock/issues/4680
if (Section == ".hipFatBinSegment" || Section == ".nvFatBinSegment") {
return false;
}

// Do not instrument user-defined sections (with names resembling
// valid C identifiers)
if (TargetTriple.isOSBinFormatELF()) {
Expand Down
Loading