[ASan] Exclude .hipFatBinSegment and .nvFatBinSegment from instrument…#2544
Open
geomin12 wants to merge 1 commit into
Open
[ASan] Exclude .hipFatBinSegment and .nvFatBinSegment from instrument…#2544geomin12 wants to merge 1 commit into
geomin12 wants to merge 1 commit into
Conversation
…ation These sections contain tightly-packed arrays of __CudaFatBinaryWrapper structs (24 bytes each). The HIP/CUDA runtime and tools like rocm-kpack walk these sections assuming a contiguous 24-byte stride. When ASan instruments globals in these sections, it adds redzones and alignment padding, breaking the layout assumption. This causes failures like: - ".hipFatBinSegment size 128 is not a multiple of wrapper size (24)" - "Unexpected magic 0x00000000 at wrapper 1" Add these sections to the exemption list in shouldInstrumentGlobal(), similar to .preinit_array, .init_array, and .fini_array. Fixes: ROCm/TheRock#4680 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
resolved in 6d92257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These sections contain tightly-packed arrays of __CudaFatBinaryWrapper structs (24 bytes each). The HIP/CUDA runtime and tools like rocm-kpack walk these sections assuming a contiguous 24-byte stride.
When ASan instruments globals in these sections, it adds redzones and alignment padding, breaking the layout assumption. This causes failures like:
Add these sections to the exemption list in shouldInstrumentGlobal(), similar to .preinit_array, .init_array, and .fini_array.
Fixes: ROCm/TheRock#4680
Noticed issue in https://github.com/ROCm/TheRock/actions/runs/24646315874/job/72061754947 and now fixed and tested here: https://github.com/ROCm/TheRock/actions/runs/25816355734/job/75859833854