Skip to content

Revert "Use amd-llvm as the default toolchain for all RDC builds"#4648

Merged
marbre merged 1 commit intomainfrom
revert-4513-users/radhaksri/rdc-asan-toolchain-fix
Apr 17, 2026
Merged

Revert "Use amd-llvm as the default toolchain for all RDC builds"#4648
marbre merged 1 commit intomainfrom
revert-4513-users/radhaksri/rdc-asan-toolchain-fix

Conversation

@amd-shiraz
Copy link
Copy Markdown
Contributor

Reverts #4513

OSError: librdc_bootstrap.so.1: cannot open shared object file: No such file or directory

issue: #4640

@amd-shiraz amd-shiraz added the ci:run-non-multi-arch Opt-in to running non-multi-arch CI on a pull request label Apr 17, 2026
@radhaksri radhaksri requested review from adam360x and bill-shuzhou-liu and removed request for amd-aakash and suchitravemuri1 April 17, 2026 16:55
@radhaksri
Copy link
Copy Markdown
Contributor

@bill-shuzhou-liu / @adam360x : Please review and approve as appropriate.

Copy link
Copy Markdown
Contributor

@radhaksri radhaksri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, to be followed up by RDC team to address a proper fix..

@ScottTodd
Copy link
Copy Markdown
Member

I'm trying to enable the tests that failed in multi-arch CI with #4647.

Using that, I triggered two test runs that should build and test just the DC Tools Core stage (hopefully faster signal than the non-multi-arch CI on this PR):

(Those were triggered with prebuilt stages foundation,compiler-runtime,math-libs,comm-libs,debug-tools,profiler-apps,iree-compiler,fusilli-libs,media-libs and workflow run id 24564363941 from https://github.com/ROCm/TheRock/actions/runs/24564363941/job/71826804444)

@ScottTodd
Copy link
Copy Markdown
Member

baseline has

Fri, 17 Apr 2026 17:32:31 GMT OSError: librdc_bootstrap.so.1: cannot open shared object file: No such file or directory

revert does not. Both have unrelated errors that I'll need to resolve as part of running these tests on multi-arch CI.

So this revert looks like it does fix the relevant tests.

@marbre
Copy link
Copy Markdown
Member

marbre commented Apr 17, 2026

We have enough signal (and approvals) that to assume this revert fixes the problem observed. Merging without waiting for full CI signal.

@marbre marbre merged commit 8f62e66 into main Apr 17, 2026
36 of 40 checks passed
@marbre marbre deleted the revert-4513-users/radhaksri/rdc-asan-toolchain-fix branch April 17, 2026 17:57
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Apr 17, 2026
dmitrii-galantsev pushed a commit that referenced this pull request Apr 28, 2026
…lds"" (#4801)

Reverts #4648

Using amd-llvm to build RDC, after
ROCm/rocm-systems#5237 got merged, addressing
the test failures seen earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run-non-multi-arch Opt-in to running non-multi-arch CI on a pull request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants