Revert "Revert "Use amd-llvm as the default toolchain for all RDC builds""#4801
Merged
dmitrii-galantsev merged 3 commits intomainfrom Apr 28, 2026
Conversation
radhaksri
requested review from
HereThereBeDragons,
adam360x,
bill-shuzhou-liu,
dmitrii-galantsev and
marbre
Contributor
|
just for the others: rocm systems in therock has the required commit included |
HereThereBeDragons
approved these changes
Apr 24, 2026
Contributor
HereThereBeDragons
left a comment
HereThereBeDragons
left a comment
There was a problem hiding this comment.
if the tests are green. please rerun the compiler stage on windows and hopefully this time it can download those requirements
…asan-toolchain-fix
…asan-toolchain-fix
adam360x
approved these changes
Apr 27, 2026
dmitrii-galantsev
approved these changes
Apr 28, 2026
dmitrii-galantsev
deleted the
revert-4648-revert-4513-users/radhaksri/rdc-asan-toolchain-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4648
Using amd-llvm to build RDC, after ROCm/rocm-systems#5237 got merged, addressing the test failures seen earlier.