Repository navigation
fix: use engine-reported model metadata; make roofline honest (v1.1.4) - #11
Merged
Merged
Conversation
- re-detect the engine after a run when the server was not ready at start (exports had engine/model_info null) - read exact parameter count and weights size from Ollama (/api/show, /api/tags) and llama.cpp (/v1/models meta); quantization/arch from LM Studio - roofline: use engine-reported size instead of the name guess (4-bit Ollama models were counted as 16-bit), stop inventing prompt throughput, report MBU/MFU > 100% instead of clamping, flag unknown GPUs and guesses, require a run file instead of made-up examples - GPU table: split RTX 3050 6GB/4GB laptop/desktop; RTX 40-series dense TFLOPS instead of sparsity figures - stop reporting a hard-coded mini-infer version - README: real roofline output from an Ollama sweep; bump to 1.1.4
Prajwal7-2002
added a commit
that referenced
this pull request
Nov 5, 2026
TTFT steps of 40 ms against a 150 ms target left 30 ms of headroom at 3 users; a slow macOS runner turned 3 users into 2 (failed once on PR #11). Use 200 ms steps and a 700 ms target: 100 ms margin on each side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servebench's core measurements are accurate (Ollama
qwen2.5:0.5b: 201 tok/s and 43 ms TTFT measured vs Ollama's own 187-221 tok/s). Its derived analyses, though, relied on guesses. This is groundwork for using servebench results in a public benchmark database, where every number must be measured or clearly labelled.Fixed
engineandmodel_infoasnull(true for every export from a day of sweeps). servebench now re-detects after the run./api/show,/api/tags) and llama.cpp (/v1/modelsmeta) report the exact parameter count and weights size →model_info.parameter_count,model_info.weights_gb. LM Studio reports quantization and architecture.servebench roofline:Test verification
/api/show);Live check (Ollama 0.35.1, RTX 3050 6GB laptop):
parameter_count: 494032768,quantization: Q4_K_M,weights_gb: 0.398andon_gpu: 100%.rooflineon a 1/2/4-user sweep (189 / 310 / 403 tok/s) gives MBU 44.8% / 36.7% / 23.8%, matching the hand calculation (tok/s × 0.398 GB ÷ users ÷ 168 GB/s). The old name guess would have exceeded 100% and been clamped.Not tested by hand yet: llama.cpp server and LM Studio metadata, which are covered only by fake-server tests.