Repository navigation
test: widen timing margins in the quick end-to-end test - #12
Merged
Merged
Conversation
TTFT steps of 40 ms against a 150 ms target left 30 ms of headroom at 3 users; a slow macOS runner turned 3 users into 2 (failed once on PR #11). Use 200 ms steps and a 700 ms target: 100 ms margin on each side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_quick_end_to_end_on_mock_serverasserts thatservebench quickfinds a capacity of exactly 3 users on the mock server. The mock's TTFT was 40 ms × requests in flight against a 150 ms target, which left only 30 ms of headroom at 3 users (120 ms). A slow macOS runner exceeded that and the test failed once on PR #11 (passed on re-run);mainhas had similar intermittent CI failures since October.Change: 200 ms steps and a 700 ms target, so 3 users = 600 ms (100 ms headroom) and 4 users = 800 ms (100 ms over). What the test checks is unchanged; no production code changes.
Test verification
ruff format --checkclean.