experiment: use a lazy bytestring hasql 'unknown'#2333
Closed
robx wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Load test has no significant change. Memory use in mem-tests seems more or less significantly decreased: |
Member
Awesome! And this is by removing just one copy from what I understand, so it should be even better when removing more copies. To ensure we don't increase on memory usage later, it'd be good to update the following tests: postgrest/test/memory/memory-tests.sh Lines 105 to 119 in fe8b32d
Hmm, I expected this to be affected too. Once this PR is merged I'll make some bench tests. |
Contributor
Author
|
Closing this one in favour of #2349 (which includes the same change via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare #2261