nix: update bytestring-strict-builder to 0.4.5.6#2336
Closed
robx wants to merge 1 commit into
Closed
Conversation
This comes with a rewrite rule that hopefully allows us to avoid a copy of the request body.
Member
|
Hm, would this change be mutually exclusive with the change in #2333? That one seemed to give better results. |
Contributor
Author
|
The rule doesn't trigger, yet, unfortunately. If it worked, it would be equivalent as a first step, and allow us to avoid a second copy if we manage to read the body into a strict bytestring directly. The other advantage of this approach is that it's something that doesn't require potentially unwanted upstream changes, compare discussion in nikita-volkov/hasql#146 and nikita-volkov/bytestring-strict-builder#11. But if this doesn't work out quickly, we can definitely go with the forked version of hasql (#2333) momentarily and follow up after. |
Contributor
Author
|
The rewrite rule turned out not to trigger for us, closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes with a rewrite rule that hopefully allows us to avoid
a copy of the request body.