Skip to content

nix: update bytestring-strict-builder to 0.4.5.6#2336

Closed
robx wants to merge 1 commit into
PostgREST:mainfrom
robx:update-builder
Closed

nix: update bytestring-strict-builder to 0.4.5.6#2336
robx wants to merge 1 commit into
PostgREST:mainfrom
robx:update-builder

Conversation

@robx
Copy link
Copy Markdown
Contributor

@robx robx commented Jun 17, 2022

This comes with a rewrite rule that hopefully allows us to avoid
a copy of the request body.

This comes with a rewrite rule that hopefully allows us to avoid
a copy of the request body.
@steve-chavez
Copy link
Copy Markdown
Member

Hm, would this change be mutually exclusive with the change in #2333? That one seemed to give better results.

@robx
Copy link
Copy Markdown
Contributor Author

robx commented Jun 17, 2022

The rule doesn't trigger, yet, unfortunately. If it worked, it would be equivalent as a first step, and allow us to avoid a second copy if we manage to read the body into a strict bytestring directly.

The other advantage of this approach is that it's something that doesn't require potentially unwanted upstream changes, compare discussion in nikita-volkov/hasql#146 and nikita-volkov/bytestring-strict-builder#11.

But if this doesn't work out quickly, we can definitely go with the forked version of hasql (#2333) momentarily and follow up after.

@robx
Copy link
Copy Markdown
Contributor Author

robx commented Aug 10, 2022

The rewrite rule turned out not to trigger for us, closing this.

@robx robx closed this Aug 10, 2022
@robx robx deleted the update-builder branch August 10, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants