Skip to content

Conversion of character and province variables #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
IhateTrains wants to merge 18 commits into
base: master
Choose a base branch
from

Merge branch 'master' into variables-conversion

b7c042f
Select commit
Loading
Failed to load commit list.
Draft

Conversion of character and province variables #2895

Merge branch 'master' into variables-conversion
b7c042f
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Apr 5, 2026 in 0s

2 new issues (0 max.) of at least severity.

Annotations

Check notice on line 151 in ImperatorToCK3.UnitTests/CK3/Provinces/ProvincesTests.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

ImperatorToCK3.UnitTests/CK3/Provinces/ProvincesTests.cs#L151 

Remove this commented out code.

Check warning on line 5 in ImperatorToCK3/Imperator/CharacterVariable.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

ImperatorToCK3/Imperator/CharacterVariable.cs#L5 

Implement 'IEquatable<T>' in value type 'Variable'.
View more details on Codacy Production