Conversion of character and province variables #3018
build_dev_version.yml
on: pull_request
Matrix: Upload development build
Annotations
12 warnings
|
Upload development build (linux-x64)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: rokibhasansagar/purge-artifacts-action@master. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Upload development build (linux-x64):
ImperatorToCK3/Imperator/Diplomacy/Dependency.cs#L12
TODO use Imperator subject type definitions to determine how the subject should be treated in CK3 (contracts and obligations) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (linux-x64):
ImperatorToCK3/Imperator/Diplomacy/Dependency.cs#L11
TODO don't convert tributaries as vassals (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (linux-x64):
ImperatorToCK3/Imperator/Characters/Character.cs#L181
TODO also handle "tick" (days remaining) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (linux-x64):
ImperatorToCK3/Imperator/Characters/Character.cs#L173
TODO use CharacterVariable<T> struct here (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (linux-x64):
ImperatorToCK3/Imperator/Characters/Character.cs#L159
TODO check if antigonus is converted bald (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (linux-x64):
ImperatorToCK3/CK3/Titles/LandedTitles.cs#L965
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (linux-x64):
ImperatorToCK3/CK3/Titles/LandedTitles.cs#L911
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (linux-x64):
ImperatorToCK3/CK3/Localization/CK3LocBlock.cs#L8
TODO add ILocBlock interface that both this and commonItems' LocBlock would implement. (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
|
|
Upload development build (linux-x64):
ImperatorToCK3/CK3/CK3LocDB.cs#L104
TODO add unit test for combining loc from all the sources into one locblock (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Upload development build (win-x64)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: rokibhasansagar/purge-artifacts-action@master. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
ImperatorToCK3-linux-x64-dev-refs-pull-2895-merge
|
112 MB |
sha256:948a7c21427baa91048c17162f0d20887171c555dad8848b3af3f42b3c24182a
|
|
|
ImperatorToCK3-win-x64-dev-refs-pull-2895-merge
|
136 MB |
sha256:4af9e82bde0612f871f6bc61133471dbee6cd57c36ced99488d43fac347717b6
|
|