Turboprop freighter fixes

.gitignore

@@ -143,8 +143,6 @@ aviary/reports/
 
 #VSCode user settings
 .vscode/
-#VSCode extensions
-.continue/
 
 # Built docs
 _build/

aviary/core/aviary_group.py

@@ -159,7 +159,7 @@ def configure(self):
 
         # Temporarily add extra stuff here, probably patched soon
         # add a check for traj using hasattr for pre-mission tests.
-        if mission_method is ENERGY_STATE and hasattr(self, 'traj'):
+        if hasattr(self, 'traj'):
             # Set a more appropriate solver for dymos when the phases are linked.
             if MPI and isinstance(self.traj.phases.linear_solver, om.PETScKrylov):
                 # When any phase is connected with input_initial = True, dymos puts

aviary/docs/examples_unreviewed/detailed_takeoff_landing.ipynb

@@ -2,7 +2,7 @@
  "cells": [
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 8,
    "metadata": {
     "tags": [
      "remove-cell"
@@ -84,9 +84,49 @@
   },
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 9,
    "metadata": {},
-   "outputs": [],
+   "outputs": [
+    {
+     "name": "stderr",
+     "output_type": "stream",
+     "text": [
+      "Warning: Variable 'aircraft:design:touchdown_mass_max' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'mission:reserve_fuel_additional' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'aircraft:design:cruise_altitude' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'aircraft:design:gross_mass' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'aircraft:design:range' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'aircraft:design:thrust_takeoff_per_eng' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'aircraft:design:cruise_mach' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'mission:fuel_flow_scaler' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n",
+      "Warning: Variable 'mission:takeoff:fuel' is not in meta_data nor in 'guess_names'. It will be ignored.\n",
+      "\n"
+     ]
+    },
+    {
+     "ename": "KeyError",
+     "evalue": "'KeyError: key not found: mission:design:range'",
+     "output_type": "error",
+     "traceback": [
+      "\u001b[31m---------------------------------------------------------------------------\u001b[39m",
+      "\u001b[31mKeyError\u001b[39m                                  Traceback (most recent call last)",
+      "\u001b[36mCell\u001b[39m\u001b[36m \u001b[39m\u001b[32mIn[9]\u001b[39m\u001b[32m, line 316\u001b[39m\n\u001b[32m    312\u001b[39m \u001b[38;5;66;03m# Load aircraft and options data from user\u001b[39;00m\n\u001b[32m    313\u001b[39m \u001b[38;5;66;03m# Allow for user overrides here\u001b[39;00m\n\u001b[32m    314\u001b[39m prob.load_inputs(\u001b[33m'\u001b[39m\u001b[33mmodels/aircraft/test_aircraft/aircraft_for_bench_solved2dof.csv\u001b[39m\u001b[33m'\u001b[39m, phase_info)\n\u001b[32m--> \u001b[39m\u001b[32m316\u001b[39m \u001b[43mprob\u001b[49m\u001b[43m.\u001b[49m\u001b[43mcheck_and_preprocess_inputs\u001b[49m\u001b[43m(\u001b[49m\u001b[43m)\u001b[49m\n\u001b[32m    318\u001b[39m prob.build_model()\n\u001b[32m    320\u001b[39m prob.add_driver(optimizer, max_iter=\u001b[32m60\u001b[39m)\n",
+      "\u001b[36mFile \u001b[39m\u001b[32m~/Aviary/aviary/core/aviary_problem.py:268\u001b[39m, in \u001b[36mAviaryProblem.check_and_preprocess_inputs\u001b[39m\u001b[34m(self, verbosity)\u001b[39m\n\u001b[32m    266\u001b[39m         group.check_and_preprocess_inputs(verbosity=verbosity)\n\u001b[32m    267\u001b[39m \u001b[38;5;28;01melse\u001b[39;00m:\n\u001b[32m--> \u001b[39m\u001b[32m268\u001b[39m     \u001b[38;5;28;43mself\u001b[39;49m\u001b[43m.\u001b[49m\u001b[43mmodel\u001b[49m\u001b[43m.\u001b[49m\u001b[43mcheck_and_preprocess_inputs\u001b[49m\u001b[43m(\u001b[49m\u001b[43mverbosity\u001b[49m\u001b[43m=\u001b[49m\u001b[43mverbosity\u001b[49m\u001b[43m)\u001b[49m\n",
+      "\u001b[36mFile \u001b[39m\u001b[32m~/Aviary/aviary/core/aviary_group.py:402\u001b[39m, in \u001b[36mcheck_and_preprocess_inputs\u001b[39m\u001b[34m(self, verbosity)\u001b[39m\n\u001b[32m    393\u001b[39m \u001b[38;5;66;03m# PREPROCESSORS #\u001b[39;00m\n\u001b[32m    394\u001b[39m preprocess_options(\n\u001b[32m    395\u001b[39m     aviary_inputs,\n\u001b[32m    396\u001b[39m     engine_models=\u001b[38;5;28mself\u001b[39m.engine_models,\n\u001b[32m    397\u001b[39m     verbosity=verbosity,\n\u001b[32m    398\u001b[39m     metadata=\u001b[38;5;28mself\u001b[39m.meta_data,\n\u001b[32m    399\u001b[39m )\n\u001b[32m    401\u001b[39m \u001b[38;5;28mself\u001b[39m.initialization_guesses = initialization_guessing(\n\u001b[32m--> \u001b[39m\u001b[32m402\u001b[39m     \u001b[38;5;28mself\u001b[39m.aviary_inputs, \u001b[38;5;28mself\u001b[39m.initialization_guesses, \u001b[38;5;28mself\u001b[39m.engine_models\n\u001b[32m    403\u001b[39m )\n\u001b[32m    405\u001b[39m \u001b[38;5;66;03m# This function sets all the following defaults if they were not already set:\u001b[39;00m\n\u001b[32m    406\u001b[39m \u001b[38;5;66;03m# self.pre_mission_info, self_post_mission_info,\u001b[39;00m\n\u001b[32m    407\u001b[39m \u001b[38;5;66;03m# self.require_range_residual, self.target_range\u001b[39;00m\n\u001b[32m    408\u001b[39m \u001b[38;5;66;03m# Other specific self.*** are defined in here as well that are specific to each builder\u001b[39;00m\n\u001b[32m    409\u001b[39m \u001b[38;5;28mself\u001b[39m.configurator.initial_guesses(\u001b[38;5;28mself\u001b[39m)\n",
+      "\u001b[36mFile \u001b[39m\u001b[32m~/Aviary/aviary/utils/process_input_decks.py:342\u001b[39m, in \u001b[36minitialization_guessing\u001b[39m\u001b[34m(aircraft_values, initialization_guesses, engine_models)\u001b[39m\n\u001b[32m    337\u001b[39m \u001b[38;5;28;01melif\u001b[39;00m reserves == \u001b[32m0\u001b[39m:\n\u001b[32m    338\u001b[39m     reserves += reserve_val\n\u001b[32m    339\u001b[39m     reserves += reserve_frac * (\n\u001b[32m    340\u001b[39m         num_pax\n\u001b[32m    341\u001b[39m         * initialization_guesses[\u001b[33m'\u001b[39m\u001b[33mfuel_burn_per_passenger_mile\u001b[39m\u001b[33m'\u001b[39m]\n\u001b[32m--> \u001b[39m\u001b[32m342\u001b[39m         * aircraft_values.get_val(Aircraft.Design.RANGE, units=\u001b[33m'\u001b[39m\u001b[33mNM\u001b[39m\u001b[33m'\u001b[39m)\n\u001b[32m    343\u001b[39m     )\n\u001b[32m    344\u001b[39m \u001b[38;5;28;01melif\u001b[39;00m reserves < \u001b[32m10\u001b[39m:\n\u001b[32m    345\u001b[39m     reserves *= (\n\u001b[32m    346\u001b[39m         num_pax\n\u001b[32m    347\u001b[39m         * initialization_guesses[\u001b[33m'\u001b[39m\u001b[33mfuel_burn_per_passenger_mile\u001b[39m\u001b[33m'\u001b[39m]\n\u001b[32m    348\u001b[39m         * aircraft_values.get_val(Aircraft.Design.RANGE, units=\u001b[33m'\u001b[39m\u001b[33mNM\u001b[39m\u001b[33m'\u001b[39m)\n\u001b[32m    349\u001b[39m     )\n",
+      "\u001b[36mFile \u001b[39m\u001b[32m~/Aviary/aviary/utils/named_values.py:147\u001b[39m, in \u001b[36mNamedValues.get_val\u001b[39m\u001b[34m(self, key, units)\u001b[39m\n\u001b[32m    144\u001b[39m item = \u001b[38;5;28mself\u001b[39m._mapping.get(key, _UNDEFINED)\n\u001b[32m    146\u001b[39m \u001b[38;5;28;01mif\u001b[39;00m item \u001b[38;5;129;01mis\u001b[39;00m _UNDEFINED:\n\u001b[32m--> \u001b[39m\u001b[32m147\u001b[39m     \u001b[38;5;28;01mraise\u001b[39;00m \u001b[38;5;167;01mKeyError\u001b[39;00m(\u001b[33mf\u001b[39m\u001b[33m'\u001b[39m\u001b[33mKeyError: key not found: \u001b[39m\u001b[38;5;132;01m{\u001b[39;00mkey\u001b[38;5;132;01m}\u001b[39;00m\u001b[33m'\u001b[39m)\n\u001b[32m    149\u001b[39m val, old_units = item\n\u001b[32m    151\u001b[39m \u001b[38;5;28;01mif\u001b[39;00m old_units != units:\n",
+      "\u001b[31mKeyError\u001b[39m: 'KeyError: key not found: mission:design:range'"
+     ]
+    }
+   ],
    "source": [
     "import openmdao.api as om\n",
     "\n",

aviary/interface/reports.py

@@ -32,7 +32,6 @@ def register_custom_reports():
         class_name='AviaryProblem',
         method='run_driver',
         pre_or_post='post',
-        # **kwargs
     )
 
     register_report(
@@ -148,7 +147,7 @@ def sizing_results(prob: AviaryProblem):
         prob.save_results(report_file)
 
 
-def subsystem_report(prob: AviaryProblem, **kwargs):
+def subsystem_report(prob: AviaryProblem):
     """
     Loops through all subsystem builders in the AviaryProblem calls their write_report
     method. All generated report files are placed in the "reports/subsystem_reports" folder.
@@ -176,7 +175,7 @@ def subsystem_report(prob: AviaryProblem, **kwargs):
     subsystems = model.subsystems  # TODO: redo for multimissions
 
     for subsystem in subsystems:
-        subsystem.report(prob, reports_folder, **kwargs)
+        subsystem.report(prob, reports_folder)
 
 
 def mission_report(prob: AviaryProblem, **kwargs):

aviary/mission/two_dof/ode/landing_ode.py

@@ -1,4 +1,5 @@
 import numpy as np
+import openmdao.api as om
 
 from aviary.mission.two_dof.ode.landing_eom import (
     GlideConditionComponent,
@@ -35,13 +36,39 @@ def setup(self):
             promotes_outputs=[Mission.Landing.INITIAL_ALTITUDE],
         )
 
+        alias_comp = om.ExecComp(
+            'alt=airport_alt',
+            alt={
+                'val': np.zeros(1),
+                'units': 'ft',
+            },
+            airport_alt={'val': np.zeros(1), 'units': 'ft'},
+            has_diag_partials=True,
+        )
+
+        alias_comp.add_expr(
+            'mach=landing_mach',
+            mach={'val': np.zeros(1), 'units': 'unitless'},
+            landing_mach={'val': np.zeros(1), 'units': 'unitless'},
+        )
+
         self.add_subsystem(
-            name='atmosphere',
-            subsys=Atmosphere(num_nodes=1, input_speed_type=SpeedType.MACH),
+            'alias_landing_phase',
+            alias_comp,
             promotes_inputs=[
-                (Dynamic.Mission.ALTITUDE, Mission.Landing.INITIAL_ALTITUDE),
-                (Dynamic.Atmosphere.MACH, Mission.Landing.INITIAL_MACH),
+                ('airport_alt', Mission.Landing.AIRPORT_ALTITUDE),
+                ('landing_mach', Mission.Landing.INITIAL_MACH),
             ],
+            promotes_outputs=[
+                ('alt', Dynamic.Mission.ALTITUDE),
+                ('mach', Dynamic.Atmosphere.MACH),
+            ],
+        )
+
+        self.add_subsystem(
+            name='atmosphere',
+            subsys=Atmosphere(num_nodes=1, input_speed_type=SpeedType.MACH),
+            promotes_inputs=[Dynamic.Mission.ALTITUDE, Dynamic.Atmosphere.MACH],
             promotes_outputs=[
                 Dynamic.Atmosphere.DENSITY,
                 Dynamic.Atmosphere.SPEED_OF_SOUND,
@@ -72,14 +99,9 @@ def setup(self):
                     aero_system,
                     promotes_inputs=[
                         '*',
-                        (
-                            Dynamic.Mission.ALTITUDE,
-                            Mission.Landing.INITIAL_ALTITUDE,
-                        ),
                         Dynamic.Atmosphere.DENSITY,
                         Dynamic.Atmosphere.SPEED_OF_SOUND,
                         Dynamic.Atmosphere.DYNAMIC_VISCOSITY,
-                        ('airport_alt', Mission.Landing.AIRPORT_ALTITUDE),
                         (Dynamic.Atmosphere.MACH, Mission.Landing.INITIAL_MACH),
                         Dynamic.Atmosphere.DYNAMIC_PRESSURE,
                         ('flap_defl', Aircraft.Wing.FLAP_DEFLECTION_LANDING),
@@ -108,11 +130,7 @@ def setup(self):
                 propulsion_mission = self.add_subsystem(
                     subsystem.name,
                     propulsion_system,
-                    promotes_inputs=[
-                        '*',
-                        (Dynamic.Mission.ALTITUDE, Mission.Landing.AIRPORT_ALTITUDE),
-                        (Dynamic.Atmosphere.MACH, Mission.Landing.INITIAL_MACH),
-                    ],
+                    promotes_inputs=['*'],
                     promotes_outputs=[(Dynamic.Vehicle.Propulsion.THRUST_TOTAL, 'thrust_idle')],
                 )
                 propulsion_mission.set_input_defaults(Dynamic.Vehicle.Propulsion.THROTTLE, 0.0)
@@ -150,7 +168,7 @@ def setup(self):
             name='atmosphere_td',
             subsys=Atmosphere(num_nodes=1),
             promotes_inputs=[
-                (Dynamic.Mission.ALTITUDE, Mission.Landing.AIRPORT_ALTITUDE),
+                Dynamic.Mission.ALTITUDE,
                 (Dynamic.Mission.VELOCITY, 'TAS_touchdown'),
             ],
             promotes_outputs=[
@@ -175,7 +193,6 @@ def setup(self):
             ),
             promotes_inputs=[
                 '*',
-                (Dynamic.Mission.ALTITUDE, Mission.Landing.AIRPORT_ALTITUDE),
                 (Dynamic.Atmosphere.DENSITY, 'rho_td'),
                 (Dynamic.Atmosphere.SPEED_OF_SOUND, 'sos_td'),
                 (Dynamic.Atmosphere.DYNAMIC_VISCOSITY, 'viscosity_td'),

aviary/mission/two_dof/ode/simple_cruise_ode.py

@@ -84,8 +84,8 @@ def setup(self):
         bal = om.BalanceComp(
             name=Dynamic.Vehicle.Propulsion.THROTTLE,
             val=np.ones(nn),
-            upper=1.0,
-            lower=0.0,
+            # upper=1.0,
+            # lower=0.0,
             units='unitless',
             lhs_name=Dynamic.Vehicle.Propulsion.THRUST_TOTAL,
             rhs_name=Dynamic.Vehicle.DRAG,

aviary/models/aircraft/large_turboprop_freighter/electrified_phase_info.py

@@ -1,13 +1,10 @@
-from aviary.variable_info.enums import SpeedType, PhaseType, ThrottleAllocation
+from aviary.variable_info.enums import PhaseType, SpeedType
 
 # Energy method
 energy_phase_info = {
-    'pre_mission': {
-        'include_takeoff': False,
-        'optimize_mass': True,
-    },
+    'pre_mission': {'include_takeoff': False, 'optimize_mass': True},
     'climb': {
-        'subsystem_options': {'core_aerodynamics': {'method': 'cruise', 'solve_alpha': 'true'}},
+        'subsystem_options': {'aerodynamics': {'method': 'cruise', 'solve_alpha': True}},
         'user_options': {
             'num_segments': 5,
             'order': 3,
@@ -20,16 +17,18 @@
             'no_descent': True,
             'mass_ref': (154000, 'lbm'),
             'throttle_enforcement': 'control',
+            'throttle_bounds': ((0.2, 1), 'unitless'),
             'time_initial_bounds': ((0.0, 0.0), 'min'),
             'time_duration_bounds': ((24.0, 128.0), 'min'),
         },
         'initial_guesses': {
             'altitude': ([100.0, 21_000.0], 'ft'),
             'mach': ([0.17, 0.475], 'unitless'),
+            'throttle': ([1, 1], 'unitless'),
         },
     },
     'cruise': {
-        'subsystem_options': {'core_aerodynamics': {'method': 'cruise', 'solve_alpha': 'true'}},
+        'subsystem_options': {'aerodynamics': {'method': 'cruise', 'solve_alpha': True}},
         'user_options': {
             'num_segments': 5,
             'order': 3,
@@ -41,16 +40,18 @@
             'altitude_bounds': ((20_000.0, 22_000.0), 'ft'),
             'mass_ref': (154000, 'lbm'),
             'throttle_enforcement': 'control',
+            'throttle_bounds': ((0.2, 1), 'unitless'),
             'time_initial_bounds': ((24.0, 128.0), 'min'),
             'time_duration_bounds': ((56.5, 1000.0), 'min'),
         },
         'initial_guesses': {
             'altitude': ([21_000, 21_000.0], 'ft'),
             'mach': ([0.475, 0.475], 'unitless'),
+            'throttle': ([1, 1], 'unitless'),
         },
     },
     'descent': {
-        'subsystem_options': {'core_aerodynamics': {'method': 'cruise', 'solve_alpha': 'true'}},
+        'subsystem_options': {'aerodynamics': {'method': 'cruise', 'solve_alpha': True}},
         'user_options': {
             'num_segments': 5,
             'order': 3,
@@ -65,9 +66,11 @@
             'mass_ref': (154000, 'lbm'),
             'no_climb': True,
             'throttle_enforcement': 'control',
+            'throttle_bounds': ((0.15, 1), 'unitless'),
             'time_initial_bounds': ((80, 1056.5), 'min'),
             'time_duration_bounds': ((29.0, 128.0), 'min'),
         },
+        'initial_guesses': {'throttle': ([0.5, 0.15], 'unitless')},
     },
     'post_mission': {
         'include_landing': False,
@@ -253,19 +256,19 @@
             'throttle': ([0.956, 0.956], 'unitless'),
         },
     },
-    'electric_cruise': {
+    'cruise': {
         'user_options': {
-            'phase_type': PhaseType.BREGUET_RANGE,
+            'phase_type': PhaseType.SIMPLE_CRUISE,
             'alt_cruise': (21_000, 'ft'),
             'mach_cruise': 0.475,
+            'mass_bounds': ((0, None), 'lbm'),
+            'mass_ref': (150_000, 'lbm'),
+            'time_duration_bounds': ((0.0, 15.0), 'h'),
+            'time_duration_ref': (8, 'h'),
         },
         'initial_guesses': {
-            # [Initial mass, delta mass] for special cruise phase.
-            'mass': ([150_000.0, -35_000], 'lbm'),
-            'initial_distance': (100.0e3, 'ft'),
-            'initial_time': (1_000.0, 's'),
-            'altitude': (21_000, 'ft'),
-            'mach': (0.475, 'unitless'),
+            'mass': ([150_000.0, 115000], 'lbm'),
+            'time': ([1516.0, 2100.0], 's'),
         },
     },
     'desc1': {
@@ -277,7 +280,7 @@
             'input_speed_type': SpeedType.MACH,
             'time_duration_bounds': ((300.0, 1800.0), 's'),
             'time_duration_ref': (1000, 's'),
-            'altitude_initial': (21_000, 'ft'),
+            # 'altitude_initial': (21_000, 'ft'),
             'altitude_final': (10_000, 'ft'),
             'altitude_bounds': ((10000.0, 21_000.0), 'ft'),
             'altitude_ref': (20_000, 'ft'),

aviary/models/aircraft/large_turboprop_freighter/large_turboprop_freighter_GASP.csv

@@ -9,7 +9,10 @@ settings:mass_method, GASP
 ############
 # AIRCRAFT #
 ############
-aircraft:design:subsonic_drag_coeff_factor, 1.447, unitless
+# This was the original value in this file. We needed to decrease the drag
+# to get a good optimization.
+# aircraft:design:subsonic_drag_coeff_factor, 1.447, unitless
+aircraft:design:subsonic_drag_coeff_factor, 1.33, unitless
 
 # Design
 aircraft:design:cg_delta, 0.25, unitless
@@ -49,7 +52,7 @@ aircraft:crew_and_payload:water_mass_per_occupant, 0, lbm
 
 # Engine/Propulsion
 # setting electrical mass may not do anything
-aircraft:electrical:mass, 300, lbm
+#aircraft:electrical:mass, 300, lbm
 aircraft:engine:additional_mass_fraction, 0.34, unitless
 aircraft:engine:data_file, models/engines/turboshaft_4465hp.csv
 aircraft:engine:mass_scaler, 1, unitless