Turboprop freighter fixes#1098
Merged
Merged
Conversation
Jason turbo
Jason turbo2
…ed extrapolation.
Fix an indentation error in the Hamilton Standard interps that affected extrapolation.
…/om-Aviary into turboprop_freighter_fixes
… edge of tolerance
…separate unittests
…/om-Aviary into turboprop_freighter_fixes
ehariton
reviewed
Apr 28, 2026
| bal = om.BalanceComp( | ||
| name=Dynamic.Vehicle.Propulsion.THROTTLE, | ||
| val=np.ones(nn), | ||
| upper=1.0, |
Contributor
There was a problem hiding this comment.
Are you sure you want to take these constraints out? I thought we also had an option in the ODEs to turn this constraint on vs. off.
Contributor
Author
There was a problem hiding this comment.
Ken removed them to help with convergence. Throttle should already have a path constraint as far as I'm aware, so I think this was overconstraining the problem
ehariton
reviewed
Apr 28, 2026
| 'subsystem_options': {'core_aerodynamics': {'method': 'cruise', 'solve_alpha': 'true'}}, | ||
| 'subsystem_options': {'aerodynamics': {'method': 'cruise', 'solve_alpha': True}}, | ||
| 'user_options': { | ||
| 'num_segments': 5, |
Contributor
There was a problem hiding this comment.
If this system is having trouble converging, I'd say reduce the number of segments here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A mix of bugfixes, feature additions, and model changes necessary for the electrified turboprop regional aircraft
Related Issues
Backwards incompatibilities
None
New Dependencies
None