Skip to content

Ensure consistent passwords during testing #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erictheise merged 1 commit into from
Feb 4, 2026
Merged

Ensure consistent passwords during testing #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/controllers/sessions_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,24 +42,24 @@ def test_login
assert_response :success
assert_template "sessions/new"

get login_path, :params => { :username => user.display_name, :password => "test" }
get login_path, :params => { :username => user.display_name, :password => "s3cr3t" }
assert_response :success
assert_template "sessions/new"

post login_path, :params => { :username => user.display_name, :password => "test" }
post login_path, :params => { :username => user.display_name, :password => "s3cr3t" }
assert_redirected_to root_path

post login_path, :params => { :username => " #{user.display_name}", :password => "test" }
post login_path, :params => { :username => " #{user.display_name}", :password => "s3cr3t" }
assert_redirected_to root_path

post login_path, :params => { :username => "#{user.display_name} ", :password => "test" }
post login_path, :params => { :username => "#{user.display_name} ", :password => "s3cr3t" }
assert_redirected_to root_path
end

def test_login_remembered
user = create(:user)

post login_path, :params => { :username => user.display_name, :password => "test", :remember_me => "yes" }
post login_path, :params => { :username => user.display_name, :password => "s3cr3t", :remember_me => "yes" }
assert_redirected_to root_path

assert_equal 28 * 86400, session[:_remember_for]
Expand All @@ -68,7 +68,7 @@ def test_login_remembered
def test_login_not_remembered
user = create(:user)

post login_path, :params => { :username => user.display_name, :password => "test", :remember_me => "0" }
post login_path, :params => { :username => user.display_name, :password => "s3cr3t", :remember_me => "0" }
assert_redirected_to root_path

assert_nil session[:_remember_for]
Expand Down
2 changes: 1 addition & 1 deletion test/factories/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

pass_crypt = PasswordHash.create("test").first
pass_crypt = PasswordHash.create("s3cr3t").first

FactoryBot.define do
factory :user do
Expand Down
64 changes: 32 additions & 32 deletions test/integration/login_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_login_email_password_duplicate
user = create(:user)
_uppercase_user = build(:user, :email => user.email.upcase).tap { |u| u.save(:validate => false) }

try_password_login user.email, "test"
try_password_login user.email, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -36,7 +36,7 @@ def test_login_email_password_duplicate_upcase
user = create(:user)
uppercase_user = build(:user, :email => user.email.upcase).tap { |u| u.save(:validate => false) }

try_password_login uppercase_user.email, "test"
try_password_login uppercase_user.email, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", uppercase_user.display_name
Expand All @@ -47,7 +47,7 @@ def test_login_email_password_duplicate_titlecase
user = create(:user)
_uppercase_user = build(:user, :email => user.email.upcase).tap { |u| u.save(:validate => false) }

try_password_login user.email.titlecase, "test"
try_password_login user.email.titlecase, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -57,7 +57,7 @@ def test_login_email_password_duplicate_titlecase
def test_login_email_password
user = create(:user)

try_password_login user.email, "test"
try_password_login user.email, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -66,7 +66,7 @@ def test_login_email_password
def test_login_email_password_upcase
user = create(:user)

try_password_login user.email.upcase, "test"
try_password_login user.email.upcase, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -75,7 +75,7 @@ def test_login_email_password_upcase
def test_login_email_password_titlecase
user = create(:user)

try_password_login user.email.titlecase, "test"
try_password_login user.email.titlecase, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -84,7 +84,7 @@ def test_login_email_password_titlecase
def test_login_email_password_pending
user = create(:user, :pending)

try_password_login user.email, "test"
try_password_login user.email, "s3cr3t"

assert_template "confirm"
assert_select "span.username", false
Expand All @@ -93,7 +93,7 @@ def test_login_email_password_pending
def test_login_email_password_pending_upcase
user = create(:user, :pending)

try_password_login user.email.upcase, "test"
try_password_login user.email.upcase, "s3cr3t"

assert_template "confirm"
assert_select "span.username", false
Expand All @@ -102,7 +102,7 @@ def test_login_email_password_pending_upcase
def test_login_email_password_pending_titlecase
user = create(:user, :pending)

try_password_login user.email.titlecase, "test"
try_password_login user.email.titlecase, "s3cr3t"

assert_template "confirm"
assert_select "span.username", false
Expand All @@ -111,7 +111,7 @@ def test_login_email_password_pending_titlecase
def test_login_email_password_suspended
user = create(:user, :suspended)

try_password_login user.email, "test"
try_password_login user.email, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -123,7 +123,7 @@ def test_login_email_password_suspended
def test_login_email_password_suspended_upcase
user = create(:user, :suspended)

try_password_login user.email.upcase, "test"
try_password_login user.email.upcase, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -135,7 +135,7 @@ def test_login_email_password_suspended_upcase
def test_login_email_password_suspended_titlecase
user = create(:user, :suspended)

try_password_login user.email.titlecase, "test"
try_password_login user.email.titlecase, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -148,7 +148,7 @@ def test_login_email_password_blocked
user = create(:user)
create(:user_block, :needs_view, :user => user)

try_password_login user.email, "test"
try_password_login user.email, "s3cr3t"

assert_template "user_blocks/show"
assert_select "span.username", user.display_name
Expand All @@ -158,7 +158,7 @@ def test_login_email_password_blocked_upcase
user = create(:user)
create(:user_block, :needs_view, :user => user)

try_password_login user.email.upcase, "test"
try_password_login user.email.upcase, "s3cr3t"

assert_template "user_blocks/show"
assert_select "span.username", user.display_name
Expand All @@ -168,7 +168,7 @@ def test_login_email_password_blocked_titlecase
user = create(:user)
create(:user_block, :needs_view, :user => user)

try_password_login user.email.titlecase, "test"
try_password_login user.email.titlecase, "s3cr3t"

assert_template "user_blocks/show"
assert_select "span.username", user.display_name
Expand All @@ -182,7 +182,7 @@ def test_login_username_password_duplicate
user = create(:user)
_uppercase_user = build(:user, :display_name => user.display_name.upcase).tap { |u| u.save(:validate => false) }

try_password_login user.display_name, "test"
try_password_login user.display_name, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -193,7 +193,7 @@ def test_login_username_password_duplicate_upcase
user = create(:user)
uppercase_user = build(:user, :display_name => user.display_name.upcase).tap { |u| u.save(:validate => false) }

try_password_login uppercase_user.display_name, "test"
try_password_login uppercase_user.display_name, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", uppercase_user.display_name
Expand All @@ -204,7 +204,7 @@ def test_login_username_password_duplicate_downcase
user = create(:user)
_uppercase_user = build(:user, :display_name => user.display_name.upcase).tap { |u| u.save(:validate => false) }

try_password_login user.display_name.downcase, "test"
try_password_login user.display_name.downcase, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -214,7 +214,7 @@ def test_login_username_password_duplicate_downcase
def test_login_username_password
user = create(:user)

try_password_login user.display_name, "test"
try_password_login user.display_name, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -223,7 +223,7 @@ def test_login_username_password
def test_login_username_password_upcase
user = create(:user)

try_password_login user.display_name.upcase, "test"
try_password_login user.display_name.upcase, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -232,7 +232,7 @@ def test_login_username_password_upcase
def test_login_username_password_downcase
user = create(:user)

try_password_login user.display_name.downcase, "test"
try_password_login user.display_name.downcase, "s3cr3t"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -241,7 +241,7 @@ def test_login_username_password_downcase
def test_login_username_password_pending
user = create(:user, :pending)

try_password_login user.display_name, "test"
try_password_login user.display_name, "s3cr3t"

assert_template "confirm"
assert_select "span.username", false
Expand All @@ -250,7 +250,7 @@ def test_login_username_password_pending
def test_login_username_password_pending_upcase
user = create(:user, :pending)

try_password_login user.display_name.upcase, "test"
try_password_login user.display_name.upcase, "s3cr3t"

assert_template "confirm"
assert_select "span.username", false
Expand All @@ -259,7 +259,7 @@ def test_login_username_password_pending_upcase
def test_login_username_password_pending_downcase
user = create(:user, :pending)

try_password_login user.display_name.downcase, "test"
try_password_login user.display_name.downcase, "s3cr3t"

assert_template "confirm"
assert_select "span.username", false
Expand All @@ -268,7 +268,7 @@ def test_login_username_password_pending_downcase
def test_login_username_password_suspended
user = create(:user, :suspended)

try_password_login user.display_name, "test"
try_password_login user.display_name, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -280,7 +280,7 @@ def test_login_username_password_suspended
def test_login_username_password_suspended_upcase
user = create(:user, :suspended)

try_password_login user.display_name.upcase, "test"
try_password_login user.display_name.upcase, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -292,7 +292,7 @@ def test_login_username_password_suspended_upcase
def test_login_username_password_suspended_downcase
user = create(:user, :suspended)

try_password_login user.display_name.downcase, "test"
try_password_login user.display_name.downcase, "s3cr3t"

assert_template "sessions/new"
assert_select "span.username", false
Expand All @@ -305,7 +305,7 @@ def test_login_username_password_blocked
user = create(:user)
create(:user_block, :needs_view, :user => user)

try_password_login user.display_name.upcase, "test"
try_password_login user.display_name.upcase, "s3cr3t"

assert_template "user_blocks/show"
assert_select "span.username", user.display_name
Expand All @@ -315,7 +315,7 @@ def test_login_username_password_blocked_upcase
user = create(:user)
create(:user_block, :needs_view, :user => user)

try_password_login user.display_name, "test"
try_password_login user.display_name, "s3cr3t"

assert_template "user_blocks/show"
assert_select "span.username", user.display_name
Expand All @@ -325,7 +325,7 @@ def test_login_username_password_blocked_downcase
user = create(:user)
create(:user_block, :needs_view, :user => user)

try_password_login user.display_name.downcase, "test"
try_password_login user.display_name.downcase, "s3cr3t"

assert_template "user_blocks/show"
assert_select "span.username", user.display_name
Expand All @@ -334,7 +334,7 @@ def test_login_username_password_blocked_downcase
def test_login_email_password_remember_me
user = create(:user)

try_password_login user.email, "test", "yes"
try_password_login user.email, "s3cr3t", "yes"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand All @@ -344,7 +344,7 @@ def test_login_email_password_remember_me
def test_login_username_password_remember_me
user = create(:user)

try_password_login user.display_name, "test", "yes"
try_password_login user.display_name, "s3cr3t", "yes"

assert_template "changesets/history"
assert_select "span.username", user.display_name
Expand Down
2 changes: 1 addition & 1 deletion test/integration/oauth2_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def authorize_client(user, client, options = {})
get oauth_authorization_path(options)
assert_redirected_to login_path(:referer => request.fullpath)

post login_path(:username => user.email, :password => "test")
post login_path(:username => user.email, :password => "s3cr3t")
follow_redirect!
assert_response :success

Expand Down
4 changes: 2 additions & 2 deletions test/integration/page_locale_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def test_defaulting

get "/login"
follow_redirect!
post "/login", :params => { :username => user.email, :password => "test" }
post "/login", :params => { :username => user.email, :password => "s3cr3t" }
follow_redirect!

get "/diary/new"
Expand All @@ -34,7 +34,7 @@ def test_override

get "/login"
follow_redirect!
post "/login", :params => { :username => user.email, :password => "test" }
post "/login", :params => { :username => user.email, :password => "s3cr3t" }
follow_redirect!

get "/diary"
Expand Down
2 changes: 1 addition & 1 deletion test/integration/user_blocks_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_api_revoke
assert_response :redirect
follow_redirect!
assert_response :success
post "/login", :params => { "username" => moderator.email, "password" => "test", :referer => "/user_blocks/#{block.id}/edit" }
post "/login", :params => { "username" => moderator.email, "password" => "s3cr3t", :referer => "/user_blocks/#{block.id}/edit" }
assert_response :redirect
follow_redirect!
assert_response :success
Expand Down
2 changes: 1 addition & 1 deletion test/integration/user_diaries_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_showing_create_diary_entry
assert_response :success
assert_template "sessions/new"
# We can now login
post "/login", :params => { "username" => user.email, "password" => "test", :referer => "/diary/new" }
post "/login", :params => { "username" => user.email, "password" => "s3cr3t", :referer => "/diary/new" }
assert_response :redirect
follow_redirect!
assert_response :success
Expand Down
4 changes: 2 additions & 2 deletions test/integration/user_terms_seen_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_terms_presented_at_login
follow_redirect!
assert_response :success
assert_template "sessions/new"
post "/login", :params => { :username => user.email, :password => "test", :referer => "/diary/new" }
post "/login", :params => { :username => user.email, :password => "s3cr3t", :referer => "/diary/new" }
# but now we need to look at the terms
assert_redirected_to account_terms_path(:referer => "/diary/new")
follow_redirect!
Expand All @@ -49,7 +49,7 @@ def test_terms_cant_be_circumvented
follow_redirect!
assert_response :success
assert_template "sessions/new"
post "/login", :params => { :username => user.email, :password => "test", :referer => "/diary/new" }
post "/login", :params => { :username => user.email, :password => "s3cr3t", :referer => "/diary/new" }
# but now we need to look at the terms
assert_redirected_to account_terms_path(:referer => "/diary/new")

Expand Down
Loading