Skip to content

Ensure consistent passwords during testing#366

Merged
erictheise merged 1 commit into
OpenHistoricalMap:stagingfrom
pablobm:consistent-test-passwords
Feb 4, 2026
Merged

Ensure consistent passwords during testing#366
erictheise merged 1 commit into
OpenHistoricalMap:stagingfrom
pablobm:consistent-test-passwords

Conversation

@pablobm
Copy link
Copy Markdown

@pablobm pablobm commented Feb 4, 2026

I noticed that in the latest commit (as of these lines), a change was introduced as follows:

-      fill_in "password", :with => "test"
+      fill_in "password", :with => "s3cr3t"

Upstream at OSM, this was introduced at openstreetmap#6431, as a means to work around a strange behaviour in Selenium. If changed in one place, it probably should change in all places to ensure consistency.

I quickly checked and this seems to help me when running tests locally:

staging:
2659 runs, 1106716 assertions, 104 failures, 54 errors, 0 skips

after these changes:
2659 runs, 1107275 assertions, 30 failures, 7 errors, 0 skips

Copy link
Copy Markdown
Member

@erictheise erictheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I feel like we've done this in the past but in any case it's the right thing to do.

@erictheise erictheise merged commit df0742d into OpenHistoricalMap:staging Feb 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants