Skip to content

fix(stream-importer): Ensure S3 paths always end in '/' (#0) #7117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garethhumphriesgkc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(stream-importer): Ensure S3 paths always end in '/' (#0) #7117

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cfa06d
Ensure S3 paths always end in '/'
garethhumphriesgkc Jul 28, 2026
6d187f3
Potential fix for pull request finding
garethhumphriesgkc Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions external-import/stream-importer/src/importer/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def __init__(self):
if "/" in os.environ.get("MINIO_DST_PATH")
else (os.environ.get("MINIO_DST_PATH"), "")
)
# Ensure S3 paths always end in '/'
self.minio_src_path = self.minio_src_path.rstrip("/") + "/"
self.minio_dst_path = self.minio_dst_path.rstrip("/") + "/"
Comment thread
garethhumphriesgkc marked this conversation as resolved.
Outdated
# Reject the unsafe ``src bucket == dst bucket AND dst_path is
# empty`` configuration up front. The ``bucket_exists`` /
# ``make_bucket`` plumbing below cannot defend this case
Expand Down
Loading