fix(stream-importer): Ensure S3 paths always end in '/' (#0) - #7117
Open
garethhumphriesgkc wants to merge 2 commits into
Open
fix(stream-importer): Ensure S3 paths always end in '/' (#0)#7117garethhumphriesgkc wants to merge 2 commits into
garethhumphriesgkc wants to merge 2 commits into
Conversation
When no trailing is specified, the minio calls return no data. Force the slash to always be present to prevent.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Stream Importer connector’s MinIO/S3 path handling to avoid missing objects when a configured prefix does not include a trailing /, ensuring object listing and key construction behave consistently.
Changes:
- Normalize
minio_src_path/minio_dst_pathto include a trailing/for S3-style prefixes. - Adjust startup configuration handling to reduce “no data returned” scenarios from MinIO when prefixes are provided without a trailing slash.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no trailing is specified, the minio calls return no data. Force the slash to always be present to prevent.
Proposed changes
/Related issues
Checklist
Further comments