Skip to content

Fix line Hessian bug #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelesh merged 1 commit into from
Jul 9, 2026
Merged

Fix line Hessian bug #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/opflow/model/power_bal_hiop/pbpolhiopkernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ PetscErrorCode OPFLOWComputeDenseEqualityConstraintsHessian_PBPOLHIOP(
dPt_dthetat_dVmf = Vmt * (-Gtf * sin(thetatf) + Btf * cos(thetatf));

/* dPt_Vmt = 2*Gtt*Vmt + Vmf*(Gtf*cos(thetatf) + Btf*sin(thetatf)); */
dPt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Bft * cos(thetatf));
dPt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Btf * cos(thetatf));
dPt_dVmt_dVmt = 2 * Gtt;
dPt_dVmt_dthetaf = Vmf * (Gtf * sin(thetatf) - Btf * cos(thetatf));
dPt_dVmt_dVmf = (Gtf * cos(thetatf) + Btf * sin(thetatf));
Expand Down Expand Up @@ -1544,7 +1544,7 @@ PetscErrorCode OPFLOWComputeDenseInequalityConstraintsHessian_PBPOLHIOP(
d2Pt_dthetat_dVmf = Vmt * (-Gtf * sin(thetatf) + Btf * cos(thetatf));

/* dPt_Vmt = 2*Gtt*Vmt + Vmf*(Gtf*cos(thetatf) + Btf*sin(thetatf)); */
d2Pt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Bft * cos(thetatf));
d2Pt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Btf * cos(thetatf));
d2Pt_dVmt_dVmt = 2 * Gtt;
d2Pt_dVmt_dthetaf = Vmf * (Gtf * sin(thetatf) - Btf * cos(thetatf));
d2Pt_dVmt_dVmf = (Gtf * cos(thetatf) + Btf * sin(thetatf));
Expand Down
4 changes: 2 additions & 2 deletions src/opflow/model/power_bal_hiop/pbpolrajahiopkernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1455,7 +1455,7 @@ PetscErrorCode OPFLOWComputeDenseEqualityConstraintsHessian_PBPOLRAJAHIOP(
dPt_dthetat_dVmf = Vmt * (-Gtf * sin(thetatf) + Btf * cos(thetatf));

/* dPt_Vmt = 2*Gtt*Vmt + Vmf*(Gtf*cos(thetatf) + Btf*sin(thetatf)); */
dPt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Bft * cos(thetatf));
dPt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Btf * cos(thetatf));
dPt_dVmt_dVmt = 2 * Gtt;
dPt_dVmt_dthetaf = Vmf * (Gtf * sin(thetatf) - Btf * cos(thetatf));
dPt_dVmt_dVmf = (Gtf * cos(thetatf) + Btf * sin(thetatf));
Expand Down Expand Up @@ -1800,7 +1800,7 @@ PetscErrorCode OPFLOWComputeDenseInequalityConstraintsHessian_PBPOLRAJAHIOP(
d2Pt_dthetat_dVmf = Vmt * (-Gtf * sin(thetatf) + Btf * cos(thetatf));

/* dPt_Vmt = 2*Gtt*Vmt + Vmf*(Gtf*cos(thetatf) + Btf*sin(thetatf)); */
d2Pt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Bft * cos(thetatf));
d2Pt_dVmt_dthetat = Vmf * (-Gtf * sin(thetatf) + Btf * cos(thetatf));
d2Pt_dVmt_dVmt = 2 * Gtt;
d2Pt_dVmt_dthetaf = Vmf * (Gtf * sin(thetatf) - Btf * cos(thetatf));
d2Pt_dVmt_dVmf = (Gtf * cos(thetatf) + Btf * sin(thetatf));
Expand Down
9 changes: 7 additions & 2 deletions src/opflow/model/power_bal_polar/pbpol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,18 +913,22 @@ PetscErrorCode OPFLOWComputeEqualityConstraintJacobian_PBPOL(OPFLOW opflow,
col[0] = line->startxdcloc;
val[0] = 1.0;
ierr = MatSetValues(Je, 1, row, 1, col, val, ADD_VALUES);
CHKERRQ(ierr);

col[0] = line->startxdcloc + 1;
val[0] = 1.0;
ierr = MatSetValues(Je, 1, row + 1, 1, col, val, ADD_VALUES);
CHKERRQ(ierr);
} else {
col[0] = line->startxdcloc;
val[0] = -(1.0 - line->loss1);
ierr = MatSetValues(Je, 1, row, 1, col, val, ADD_VALUES);
CHKERRQ(ierr);

col[0] = line->startxdcloc + 2;
val[0] = -1.0;
ierr = MatSetValues(Je, 1, row + 1, 1, col, val, ADD_VALUES);
CHKERRQ(ierr);
}
}
}
Expand Down Expand Up @@ -2072,7 +2076,7 @@ PetscErrorCode OPFLOWComputeEqualityConstraintsHessian_PBPOL(OPFLOW opflow,
dPt_dthetat_dVmf = Vmt * (-Gtf * sin_thetatf + Btf * cos_thetatf);

/* dPt_Vmt = 2*Gtt*Vmt + Vmf*(Gtf*cos_thetatf + Btf*sin_thetatf); */
dPt_dVmt_dthetat = Vmf * (-Gtf * sin_thetatf + Bft * cos_thetatf);
dPt_dVmt_dthetat = Vmf * (-Gtf * sin_thetatf + Btf * cos_thetatf);
dPt_dVmt_dVmt = 2 * Gtt;
dPt_dVmt_dthetaf = Vmf * (Gtf * sin_thetatf - Btf * cos_thetatf);
dPt_dVmt_dVmf = (Gtf * cos_thetatf + Btf * sin_thetatf);
Expand Down Expand Up @@ -2277,6 +2281,7 @@ PetscErrorCode OPFLOWComputeInequalityConstraintsHessian_PBPOL(OPFLOW opflow,
val[2] = gen->apf * (lambda_gloc + lambda_gloc1);

ierr = MatSetValues(H, 1, row, 3, col, val, ADD_VALUES);
CHKERRQ(ierr);

// df1_ddelPg = -(Pg - gen->pt);
// df2_ddelPg = gen->pb - Pg;
Expand Down Expand Up @@ -2510,7 +2515,7 @@ PetscErrorCode OPFLOWComputeInequalityConstraintsHessian_PBPOL(OPFLOW opflow,
d2Pt_dthetat_dVmf = Vmt * (-Gtf * sin_thetatf + Btf * cos_thetatf);

/* dPt_Vmt = 2*Gtt*Vmt + Vmf*(Gtf*cos_thetatf + Btf*sin_thetatf); */
d2Pt_dVmt_dthetat = Vmf * (-Gtf * sin_thetatf + Bft * cos_thetatf);
d2Pt_dVmt_dthetat = Vmf * (-Gtf * sin_thetatf + Btf * cos_thetatf);
d2Pt_dVmt_dVmt = 2 * Gtt;
d2Pt_dVmt_dthetaf = Vmf * (Gtf * sin_thetatf - Btf * cos_thetatf);
d2Pt_dVmt_dVmf = (Gtf * cos_thetatf + Btf * sin_thetatf);
Expand Down
Loading