Skip to content

Fix line Hessian bug#64

Merged
pelesh merged 1 commit into
olcf-hackathon-2026-devfrom
nicholson/fix-hessian-bug
Jul 9, 2026
Merged

Fix line Hessian bug#64
pelesh merged 1 commit into
olcf-hackathon-2026-devfrom
nicholson/fix-hessian-bug

Conversation

@nkoukpaizan

Copy link
Copy Markdown
Collaborator

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

This fixes a bug where Bft was used in line Hessians, instead on Btf. The implementation now matches the comment above it in pbol.cpp.

  • This has no effect on whether the current tests pass or fail. Btf=Bft when the phase/angle or tap ratio are 0, which is the case for case9, case118 and case_ACTIVSg200.
  • All models had the same bug, so comparing one to the other cannot identify the bug. This is an additional argument in favor of unit tests that compare to analytical solutions.
  • The Hessians are symmetric, and this seems to only affect the lower triangle. So it will have no effect if the solvers only use the upper triangular.

@nkoukpaizan nkoukpaizan self-assigned this Jul 7, 2026
@nkoukpaizan nkoukpaizan added the bug Something isn't working label Jul 7, 2026
@nkoukpaizan nkoukpaizan force-pushed the nicholson/fix-hessian-bug branch from 0a1f891 to efb7b8b Compare July 7, 2026 20:43
@pelesh pelesh added this to the Release 2.1 milestone Jul 8, 2026
@nkoukpaizan nkoukpaizan force-pushed the nicholson/fix-hessian-bug branch from efb7b8b to 8a07f7d Compare July 8, 2026 20:05
@nkoukpaizan nkoukpaizan changed the base branch from nicholson/hessians-porting to olcf-hackathon-2026-dev July 8, 2026 20:06
@nkoukpaizan nkoukpaizan requested a review from pelesh July 8, 2026 20:15
@pelesh pelesh merged commit 7a49d30 into olcf-hackathon-2026-dev Jul 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants