Skip to content

animeko: drop#435204

Merged
wegank merged 1 commit into
NixOS:masterfrom
qzylinra:animeko
Aug 22, 2025
Merged

animeko: drop#435204
wegank merged 1 commit into
NixOS:masterfrom
qzylinra:animeko

Conversation

@qzylinra
Copy link
Copy Markdown
Contributor

The upstream of this software does not want the application to be released on app stores.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

The upstream of this software does not want the application to be released on app stores.
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 20, 2025
@wegank wegank merged commit 1e205e3 into NixOS:master Aug 22, 2025
29 of 31 checks passed
@qzylinra qzylinra deleted the animeko branch August 22, 2025 08:36
@Him188
Copy link
Copy Markdown

Him188 commented Sep 6, 2025

Just to clearify:

We, as the upstream, did not say "The upstream of this software does not want the application to be released on app stores." We have never made such a statement.

The reason of removal in this PR is not true:

animeko = throw "'animeko' has been removed since it is unmaintained"; # Added 2025-08-20

The repository is still in active development.

@wegank wegank mentioned this pull request Sep 6, 2025
@emilazy
Copy link
Copy Markdown
Member

emilazy commented Sep 6, 2025

@Him188 Thank you for the clarification. (FWIW, “unmaintained” usually means “unmaintained in Nixpkgs”, as in this case, but we should try to be clearer.)

@qzylinra Could you explain what made you think the upstream is opposed to this packaging? It would be good to point to sources for claims like this in future.

@qzylinra
Copy link
Copy Markdown
Contributor Author

qzylinra commented Sep 6, 2025

Sorry, "unmaintained" here means there's no maintainer in nixpkgs, not upstream. The reasoning stems from the fact that it was added to fdroid, which may be outdated, vague, and possibly inappropriate. The package was added and maintained without sufficient consideration for upstream's wishes. I believe it should be added only when upstream is ready. Hopefully, upstream will review this package to see if it meets upstream expectations.

@wegank
Copy link
Copy Markdown
Member

wegank commented Sep 6, 2025

Just to clearify:

We, as the upstream, did not say "The upstream of this software does not want the application to be released on app stores." We have never made such a statement.

In open-ani/animeko#580 (comment) (archived here):

弹弹 play 希望我们尽可能保护 key 避免被滥用, 现在是允许 APP 里写 key 然后打包起来的, 更推荐我们用服务器转发. 我们必须遵守弹弹 play 的使用协议, 因此我不能授权把 key 提交给 f-droid 公开仓库.

虽然很感谢你的帮助, 但现在可能只能等弹幕服务改为 ani 服务器转发的时候 (届时客户端不需要 key) 才适合发布.

and open-ani/animeko#1308 (comment) (archived here):

现在没整发布主要是因为还有别的很多更重要的事情要做。F-Droid 要求太高(需要它去构建),需要我们做弹幕转发,这就涉及到很多复杂问题(开发,服务器带宽成本,运维,规范化等)。

You explicitly didn't want animeko to be released on F-Droid without enabling server forwarding, in order to protect the dandanplay API key from abuse. Yet in Nixpkgs, animeko is packaged with:

echo "ani.dandanplay.app.id=2qkvdr35cy" >> local.properties
echo "ani.dandanplay.app.secret=WspqhGkCD4DQbIUiXTPprrGmpn3YHFeX" >> local.properties

Where I believe the reasoning of @qzylinra stems from.

@pokon548 pokon548 mentioned this pull request Nov 17, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants