Skip to content

Stop accessing AesGcm from multiple threads in Aes256GcmRtpSizeEncryption #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KubaZ2 merged 1 commit into from
Jun 18, 2026
+4 −1
Merged

Stop accessing AesGcm from multiple threads in Aes256GcmRtpSizeEncryption #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion NetCord/Gateway/Voice/Encryption/Aes256GcmRtpSizeEncryption.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ namespace NetCord.Gateway.Voice.Encryption;

public sealed class Aes256GcmRtpSizeEncryption : IVoiceEncryption
{
private AesGcm? _decryption;
private AesGcm? _encryption;
private int _nonce;

Expand Down Expand Up @@ -60,7 +61,7 @@ public void Decrypt(RtpPacket packet, Span<byte> plaintext)
var tag = payload[^(TagSize + sizeof(int))..^sizeof(int)];
var ad = packet.ExtendedHeader;

_encryption!.Decrypt(nonce, ciphertext, tag, plaintext, ad);
_decryption!.Decrypt(nonce, ciphertext, tag, plaintext, ad);
}

public void Encrypt(ReadOnlySpan<byte> plaintext, RtpPacketWriter packet)
Expand All @@ -87,11 +88,13 @@ public void Encrypt(ReadOnlySpan<byte> plaintext, RtpPacketWriter packet)

public void SetKey(byte[] key)
{
_decryption = new(key, TagSize);
_encryption = new(key, TagSize);
}
Comment thread
KubaZ2 marked this conversation as resolved.

public void Dispose()
{
_decryption?.Dispose();
_encryption?.Dispose();
}
}