Stop accessing AesGcm from multiple threads in Aes256GcmRtpSizeEncryption#367
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Discord voice RTP-size AES-256-GCM encryption implementation to avoid using the same AesGcm instance for both encryption and decryption, which can otherwise be accessed concurrently from different threads.
Changes:
- Added a dedicated
_decryptionAesGcminstance separate from_encryption. - Switched
Decryptto use_decryptioninstead of_encryption. - Updated
SetKey/Disposeto initialize and dispose the additionalAesGcminstance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The documentation preview is available at https://preview.netcord.dev/367. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.