Repository navigation
Parse the H3 header on the catalog path as the build path does - #243
Merged
estebanzimanyi merged 1 commit intoNov 5, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
The catalog path of the provision-meos action and the openapi-validate workflow install libh3-dev with the other headers libclang reads, so the H3 functions keep the typedef H3Index on their uint64_t parameters and results. The build path of the action installs libh3-dev already, so both paths derive the same catalog. Why. Without h3api.h libclang reads H3Index as uint64_t, and the catalog the action derives without build-libmeos drops the typedef from 72 H3 functions that the catalog it derives with build-libmeos states. A consumer that generates from one path and checks against the other reads a difference neither its code nor MobilityDB causes: MobilityDB/MobilityAPI-Python#19 is the case. Measured. On MobilityDB 92c29a5fae, a catalog-path derivation in an ubuntu-24.04 container with the action's packages differs from one with libh3-dev only by the typedef H3Index on the parameters and results of 72 functions, and with libh3-dev it projects to the same MobilityAPI-Python table byte for byte as a derivation on a machine carrying libh3-dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catalog path of the provision-meos action and the openapi-validate workflow install libh3-dev with the other headers libclang reads, so the H3 functions keep the typedef H3Index on their uint64_t parameters and results. The build path of the action installs libh3-dev already, so both paths derive the same catalog.
Why. Without h3api.h libclang reads H3Index as uint64_t, and the catalog the action derives without build-libmeos drops the typedef from 72 H3 functions that the catalog it derives with build-libmeos states. A consumer that generates from one path and checks against the other reads a difference neither its code nor MobilityDB causes: MobilityDB/MobilityAPI-Python#19 is the case.
Measured. On MobilityDB 92c29a5fae, a catalog-path derivation in an ubuntu-24.04 container with the action's packages differs from one with libh3-dev only by the typedef H3Index on the parameters and results of 72 functions, and with libh3-dev it projects to the same MobilityAPI-Python table byte for byte as a derivation on a machine carrying libh3-dev.