Repository navigation
Commit 57ee7d0
committed
Parse the H3 header on the catalog path as the build path does
The catalog path of the provision-meos action and the openapi-validate workflow install libh3-dev with the other headers libclang reads, so the H3 functions keep the typedef H3Index on their uint64_t parameters and results. The build path of the action installs libh3-dev already, so both paths derive the same catalog.
Why. Without h3api.h libclang reads H3Index as uint64_t, and the catalog the action derives without build-libmeos drops the typedef from 72 H3 functions that the catalog it derives with build-libmeos states. A consumer that generates from one path and checks against the other reads a difference neither its code nor MobilityDB causes: MobilityDB/MobilityAPI-Python#19 is the case.
Measured. On MobilityDB 92c29a5fae, a catalog-path derivation in an ubuntu-24.04 container with the action's packages differs from one with libh3-dev only by the typedef H3Index on the parameters and results of 72 functions, and with libh3-dev it projects to the same MobilityAPI-Python table byte for byte as a derivation on a machine carrying libh3-dev.1 parent bf3b6cf commit 57ee7d0
2 files changed
Lines changed: 11 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
67 | | - | |
68 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| |||
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
77 | | - | |
| 78 | + | |
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
50 | | - | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
| |||
0 commit comments