Skip to content

chore(6939): add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies #41954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DDDDDanica merged 11 commits into from
May 7, 2026
Merged

chore(6939): add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies #41954

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a15778d
Initial plan
Copilot Apr 20, 2026
1848ad2
feat: add @mui/material v5, Emotion, and @mui/x-date-pickers dependen…
Copilot Apr 20, 2026
015a796
Merge branch 'main' into copilot/add-mui-material-emotion-dependencies
DDDDDanica Apr 29, 2026
b543301
chore: add the three flagged packages to .depcheckrc.yml to resolve t…
DDDDDanica May 6, 2026
429e6ac
revert: restore attribution.txt to pre-change state
Copilot May 6, 2026
827eea4
chore: update babel pins for mui runtime compatibility
Copilot May 6, 2026
9f1d3c7
chore: reapply babel core patch
Copilot May 6, 2026
d772f9a
chore: clarify babel core patch intent
Copilot May 6, 2026
ff6fbf1
Revert "chore: clarify babel core patch intent"
Copilot May 6, 2026
9addafc
Revert "chore: reapply babel core patch"
Copilot May 6, 2026
c775fd7
Update LavaMoat policies
metamaskbot May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .depcheckrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ ignores:
- 'react-compiler-runtime'
- '@fortawesome/fontawesome-free'
- 'punycode'
# peer deps of @mui/material v5, consumed internally by MUI (not imported directly)
- '@emotion/react'
- '@emotion/styled'
# v5 pre-installed ahead of migration from @material-ui/core (v4 path);
# imports switch to @mui/material in the migration branch
- '@mui/material'
# future use for Snaps date pickers; v7 supports React 17 + MUI v5
- '@mui/x-date-pickers'

#
# dev deps
Expand Down
12 changes: 0 additions & 12 deletions .yarn/patches/@babel-core-npm-7.25.9-4ae3bff7f3.patch
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions ...abel-runtime-npm-7.26.10-fe8c62510a.patch → ...babel-runtime-npm-7.29.2-b49cad1c67.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
diff --git a/helpers/construct.js b/helpers/construct.js
index aee8e70448824f509d6605e2dfa4455167442f21..00a69eba8d4c15a1f9aa318a50abb96c2ec447d9 100644
index aee8e70448824f509d6605e2dfa4455167442f21..5fe152bc1129bd8c8b7bb217ca1972ac4e089051 100644
--- a/helpers/construct.js
+++ b/helpers/construct.js
@@ -1,10 +1,22 @@
var isNativeReflectConstruct = require("./isNativeReflectConstruct.js");
@@ -1,10 +1,21 @@
-var isNativeReflectConstruct = require("./isNativeReflectConstruct.js");
-var setPrototypeOf = require("./setPrototypeOf.js");
-function _construct(t, e, r) {
- if (isNativeReflectConstruct()) return Reflect.construct.apply(null, arguments);
Expand Down
12 changes: 8 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@
"readable-stream-2@^2.3.3": "npm:readable-stream@^2.3.3",
"readable-stream-3@^3.6.2": "npm:readable-stream@^3.6.2",
"@metamask/snaps-sdk": "^11.1.0",
"@babel/core": "patch:@babel/core@npm%3A7.25.9#~/.yarn/patches/@babel-core-npm-7.25.9-4ae3bff7f3.patch",
"@babel/runtime": "patch:@babel/runtime@npm%3A7.26.10#~/.yarn/patches/@babel-runtime-npm-7.26.10-fe8c62510a.patch",
"@babel/core": "7.29.0",
Copy link
Copy Markdown

@cursor cursor Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babel/core patch dropped despite explicit request to reapply

Medium Severity

The @babel/core dependency changed from a patched version (removing a self-referencing var thisFile = require("./index.js")) to an unpatched 7.29.0. The old patch file .yarn/patches/@babel-core-npm-7.25.9-4ae3bff7f3.patch was deleted with no replacement created for 7.29.0. The PR discussion explicitly requested reapplying "Norbert's patches" to both @babel/core and @babel/runtime, but only the @babel/runtime patch was reapplied. If the self-referencing require still exists in @babel/core 7.29.0's compiled lib/index.js, this could cause LavaMoat or lockdown errors at runtime.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 827eea4. Configure here.

"@babel/runtime": "patch:@babel/runtime@npm%3A7.29.2#~/.yarn/patches/@babel-runtime-npm-7.29.2-b49cad1c67.patch",
"@spruceid/siwe-parser@npm:2.1.0": "patch:@spruceid/siwe-parser@npm%3A2.1.0#~/.yarn/patches/@spruceid-siwe-parser-npm-2.1.0-060b7ede7a.patch",
"ts-mixer@npm:^6.0.3": "patch:ts-mixer@npm%3A6.0.4#~/.yarn/patches/ts-mixer-npm-6.0.4-5d9747bdf5.patch",
"@json-schema-spec/json-pointer@npm:^0.1.2": "patch:@json-schema-spec/json-pointer@npm%3A0.1.2#~/.yarn/patches/@json-schema-spec-json-pointer-npm-0.1.2-3d06119887.patch",
Expand Down Expand Up @@ -288,9 +288,11 @@
"@metamask/perps-controller": "^4.0.0"
},
"dependencies": {
"@babel/runtime": "patch:@babel/runtime@npm%3A7.26.10#~/.yarn/patches/@babel-runtime-npm-7.26.10-fe8c62510a.patch",
"@babel/runtime": "patch:@babel/runtime@npm%3A7.29.2#~/.yarn/patches/@babel-runtime-npm-7.29.2-b49cad1c67.patch",
"@blockaid/ppom_release": "^1.5.3",
"@date-io/luxon": "^1.3.13",
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.14.1",
"@ensdomains/content-hash": "^2.5.7",
"@ethereumjs/tx": "patch:@ethereumjs/tx@npm%3A5.4.0#~/.yarn/patches/@ethereumjs-tx-npm-5.4.0-0c4a0f973e.patch",
"@ethersproject/abi": "^5.6.4",
Expand Down Expand Up @@ -423,6 +425,8 @@
"@metamask/tron-wallet-snap": "^1.25.3",
"@metamask/user-operation-controller": "^41.2.0",
"@metamask/utils": "^11.11.0",
"@mui/material": "^5.18.0",
"@mui/x-date-pickers": "^7.29.4",
"@ngraveio/bc-ur": "^1.1.13",
"@noble/hashes": "^1.3.3",
"@popperjs/core": "^2.4.0",
Expand Down Expand Up @@ -517,7 +521,7 @@
"@actions/github": "^9.1.1",
"@anthropic-ai/sdk": "^0.32.1",
"@babel/code-frame": "^7.25.9",
"@babel/core": "patch:@babel/core@npm%3A7.25.9#~/.yarn/patches/@babel-core-npm-7.25.9-4ae3bff7f3.patch",
"@babel/core": "7.29.0",
"@babel/eslint-parser": "^7.25.9",
"@babel/eslint-plugin": "^7.25.9",
"@babel/plugin-transform-class-properties": "^7.28.6",
Expand Down
Loading
Loading