Skip to content

chore(6939): add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies#41954

Merged
DDDDDanica merged 11 commits intomainfrom
copilot/add-mui-material-emotion-dependencies
May 7, 2026
Merged

chore(6939): add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies#41954
DDDDDanica merged 11 commits intomainfrom
copilot/add-mui-material-emotion-dependencies

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

  • Fetch full branch history so commit 9f1d3c76322925cba14611315f0b24ae34fde9f2 is available locally
  • Revert commit 9f1d3c76322925cba14611315f0b24ae34fde9f2 in addition to the already reverted follow-up commit
  • Re-run targeted validation for the lockfile and affected test
  • Run final review/security validation

Note

Medium Risk
Moderate risk because it changes core build/tooling dependencies (@babel/core/@babel/runtime) and updates LavaMoat policies, which could affect builds/bundling across the repo.

Overview
Pre-installs MUI v5 + related deps by adding @mui/material, @mui/x-date-pickers, and their Emotion peer dependencies (@emotion/react, @emotion/styled), and updates depcheck ignores accordingly.

Updates Babel tooling by moving @babel/core to 7.29.0 (dropping the previous Yarn patch) and updating the @babel/runtime patch to replace the construct helper polyfill with a Reflect.construct proxy; corresponding LavaMoat policy entries are adjusted for the @jridgewell/remapping dependency and new globals (e.g., structuredClone, process.features.typescript).

Refreshes yarn.lock to reflect the new/updated dependency graph.

Reviewed by Cursor Bugbot for commit c775fd7. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 20, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​mui/​x-date-pickers@​7.29.49210093100100

View full report

Copilot AI changed the title [WIP] Add @mui/material and Emotion dependencies feat: add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies Apr 20, 2026
Copilot AI requested a review from MajorLift April 20, 2026 14:31
@MajorLift
Copy link
Copy Markdown
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

No policy changes

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 Bot commented Apr 20, 2026

Builds ready [1848ad2]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24672151850 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-browserify
loadNewAccount🟡 [Show logs]
confirmTx🟡 [Show logs]
bridgeUserActions🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -52%
  • loadNewAccount/total: -52%
  • bridgeUserActions/bridge_load_page: -16%
  • bridgeUserActions/bridge_load_asset_picker: -30%
  • bridgeUserActions/bridge_search_token: -28%
  • bridgeUserActions/total: -28%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.4s
Startup Benchmarks · Samples: 100
Benchmarkchrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
startupStandardHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -22%
  • startupStandardHome/load: -11%
  • startupStandardHome/domContentLoaded: -13%
  • startupStandardHome/domInteractive: +14%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -16%
  • startupStandardHome/numNetworkReqs: -37%
  • startupStandardHome/uiStartup: -19%
  • startupStandardHome/load: -14%
  • startupStandardHome/domContentLoaded: -13%
  • startupStandardHome/backgroundConnect: -36%
  • startupStandardHome/firstReactRender: -19%
  • startupStandardHome/loadScripts: -14%
  • startupStandardHome/numNetworkReqs: -44%
  • startupStandardHome/uiStartup: -11%
  • startupStandardHome/domInteractive: -56%
  • startupStandardHome/backgroundConnect: +14%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/numNetworkReqs: -34%
  • startupStandardHome/uiStartup: -20%
  • startupStandardHome/load: -12%
  • startupStandardHome/domContentLoaded: -12%
  • startupStandardHome/domInteractive: -59%
  • startupStandardHome/backgroundConnect: -13%
  • startupStandardHome/firstReactRender: -12%
  • startupStandardHome/initialActions: -43%
  • startupStandardHome/loadScripts: -13%
  • startupStandardHome/setupStore: -60%
  • startupStandardHome/numNetworkReqs: -29%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-browserify
onboardingImportWallet🟢 [Show logs]
onboardingNewWallet🟢 [Show logs]
assetDetails🟡 [Show logs]
solanaAssetDetails🟡 [Show logs]
importSrpHome🟡 [Show logs]
sendTransactions🟡 [Show logs]
swap🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -84%
  • onboardingImportWallet/metricsToWalletReadyScreen: -37%
  • onboardingImportWallet/doneButtonToHomeScreen: -77%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: +26%
  • onboardingImportWallet/total: -43%
  • onboardingNewWallet/srpButtonToPwForm: -77%
  • onboardingNewWallet/skipBackupToMetricsScreen: -67%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -24%
  • onboardingNewWallet/doneButtonToAssetList: -32%
  • onboardingNewWallet/total: -32%
  • assetDetails/assetClickToPriceChart: -78%
  • assetDetails/total: -78%
  • solanaAssetDetails/assetClickToPriceChart: -67%
  • solanaAssetDetails/total: -67%
  • importSrpHome/loginToHomeScreen: -11%
  • importSrpHome/openAccountMenuAfterLogin: -53%
  • importSrpHome/homeAfterImportWithNewWallet: -67%
  • importSrpHome/total: -60%
  • sendTransactions/openSendPageFromHome: -19%
  • sendTransactions/reviewTransactionToConfirmationPage: +34%
  • sendTransactions/total: +31%
  • swap/openSwapPageFromHome: -96%
  • swap/fetchAndDisplaySwapQuotes: +31%
  • swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/INP: p75 208ms
  • 🟡 assetDetails/FCP: p75 2.5s
  • 🟡 solanaAssetDetails/FCP: p75 2.6s
  • 🟡 importSrpHome/FCP: p75 2.5s
  • 🟡 sendTransactions/FCP: p75 2.5s
  • 🟡 swap/FCP: p75 2.5s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-browserify
dappPageLoad🟢 [Show logs]
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 135 Bytes (0%)

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 Bot commented Apr 30, 2026

Builds ready [015a796]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 25139729040 | Baseline logs

Interaction Benchmarks · Samples: 5

⚠️ Missing data: chrome/webpack/interactionUserActions, firefox/webpack/interactionUserActions

✅ No regressions detected

Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, chrome/webpack/startupPowerUserHome, firefox/webpack/startupStandardHome, firefox/webpack/startupPowerUserHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API

⚠️ Missing data: chrome/webpack/userJourneyOnboardingImport, chrome/webpack/userJourneyOnboardingNew, chrome/webpack/userJourneyAssets, chrome/webpack/userJourneyAccountManagement, chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyOnboardingImport, firefox/webpack/userJourneyOnboardingNew, firefox/webpack/userJourneyAssets, firefox/webpack/userJourneyAccountManagement, firefox/webpack/userJourneyTransactions

✅ No regressions detected

Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 135 Bytes (0%)

@DDDDDanica DDDDDanica changed the title feat: add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies chore(6939): add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies May 1, 2026
@DDDDDanica DDDDDanica added the team-extension-platform Extension Platform team label May 6, 2026
…he dep exists while depcheck can't detect the usage
This reverts commit d772f9a.

Co-authored-by: MajorLift <[email protected]>
This reverts commit 9f1d3c7.

Co-authored-by: MajorLift <[email protected]>
@MajorLift
Copy link
Copy Markdown
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

LavaMoat validation is still running. Please retry @metamaskbot update-policies after CI validation completes.

@DDDDDanica
Copy link
Copy Markdown
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/browserify/beta/policy.json changes differ from lavamoat/browserify/main/policy.json changes
👀 lavamoat/browserify/experimental/policy.json changes differ from lavamoat/browserify/main/policy.json changes
👀 lavamoat/browserify/flask/policy.json changes differ from lavamoat/browserify/main/policy.json changes
👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

@metamaskbot metamaskbot requested a review from a team as a code owner May 6, 2026 16:45
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 Bot commented May 6, 2026

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (2 files, +31 -29)
  • 📁 lavamoat/
    • 📁 build-system/
      • 📄 policy.json +16 -15
    • 📁 webpack/
      • 📁 build/
        • 📄 policy.json +15 -14

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 Bot commented May 6, 2026

Builds ready [c775fd7]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): 51036da | Date: 5/2/2026 | Pipeline: 25448661641 | Baseline logs

Interaction Benchmarks · Samples: 5

⚠️ Missing data: chrome/webpack/interactionUserActions, firefox/webpack/interactionUserActions

✅ No regressions detected

Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, chrome/webpack/startupPowerUserHome, firefox/webpack/startupStandardHome, firefox/webpack/startupPowerUserHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API

⚠️ Missing data: chrome/webpack/userJourneyOnboardingImport, chrome/webpack/userJourneyOnboardingNew, chrome/webpack/userJourneyAssets, chrome/webpack/userJourneyAccountManagement, chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyOnboardingImport, firefox/webpack/userJourneyOnboardingNew, firefox/webpack/userJourneyAssets, firefox/webpack/userJourneyAccountManagement, firefox/webpack/userJourneyTransactions

✅ No regressions detected

Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 763.84 KiB (14.03%)
  • ui: 13.47 KiB (0.16%)
  • common: 476.48 KiB (3.65%)

@DDDDDanica DDDDDanica added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 592b3d3 May 7, 2026
203 of 204 checks passed
@DDDDDanica DDDDDanica deleted the copilot/add-mui-material-emotion-dependencies branch May 7, 2026 00:55
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
@metamaskbot metamaskbot added the release-13.31.0 Issue or pull request that will be included in release 13.31.0 label May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants