chore(6939): add @mui/material v5, Emotion, and @mui/x-date-pickers dependencies#41954
Conversation
…cies Agent-Logs-Url: https://github.com/MetaMask/metamask-extension/sessions/0ee8b395-f119-4eaa-ab64-5812ff541d11 Co-authored-by: MajorLift <[email protected]>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@metamaskbot update-policies |
|
No policy changes |
Builds ready [1848ad2]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [015a796]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
…he dep exists while depcheck can't detect the usage
0f27165 to
b543301
Compare
Agent-Logs-Url: https://github.com/MetaMask/metamask-extension/sessions/7d3e3a20-c6cb-432c-b91d-286d727f7020 Co-authored-by: MajorLift <[email protected]>
This reverts commit d772f9a. Co-authored-by: MajorLift <[email protected]>
This reverts commit 9f1d3c7. Co-authored-by: MajorLift <[email protected]>
|
@metamaskbot update-policies |
|
LavaMoat validation is still running. Please retry |
|
@metamaskbot update-policies |
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/browserify/beta/policy.json changes differ from lavamoat/browserify/main/policy.json changes |
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (2 files, +31 -29)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
|
Builds ready [c775fd7]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|



9f1d3c76322925cba14611315f0b24ae34fde9f2is available locally9f1d3c76322925cba14611315f0b24ae34fde9f2in addition to the already reverted follow-up commitNote
Medium Risk
Moderate risk because it changes core build/tooling dependencies (
@babel/core/@babel/runtime) and updates LavaMoat policies, which could affect builds/bundling across the repo.Overview
Pre-installs MUI v5 + related deps by adding
@mui/material,@mui/x-date-pickers, and their Emotion peer dependencies (@emotion/react,@emotion/styled), and updatesdepcheckignores accordingly.Updates Babel tooling by moving
@babel/coreto7.29.0(dropping the previous Yarn patch) and updating the@babel/runtimepatch to replace theconstructhelper polyfill with aReflect.constructproxy; corresponding LavaMoat policy entries are adjusted for the@jridgewell/remappingdependency and new globals (e.g.,structuredClone,process.features.typescript).Refreshes
yarn.lockto reflect the new/updated dependency graph.Reviewed by Cursor Bugbot for commit c775fd7. Bugbot is set up for automated code reviews on this repo. Configure here.