Repository navigation
Conversation
Member
|
Checked commit ohhAndy@c191d49 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ManageIQ/manageiq-ui-classic#9471
Introduced in #16365
Problem
Calling
with_status_inon an existing relation chain silently drops all precedingWHEREclauses because the scope block returns a new relation rooted atMiqTask.allinstead of merging withself:Fix
ORreduction inmerge(...)so conditions areANDed into the existing relation chain.MiqTask.unscoped.send(...)for each branch to prevent outer/default scopes from leaking into individualORclauses.spec/models/miq_task_spec.rbfor single and multiple status chaining.@miq-bot assign @jrafanie
@miq-bot add-label bug
@miq-bot add-reviewer @jrafanie