Repository navigation
Fix Task Form Bugs - #10358
Open
ohhAndy wants to merge 1 commit into
Open
Fix Task Form Bugs#10358ohhAndy wants to merge 1 commit into
ohhAndy wants to merge 1 commit into
Conversation
ohhAndy
commented
Oct 8, 2026
|
|
||
| # Add status scope | ||
| status = (opts.compact.symbolize_keys.keys & %i[ok queued error warn running]) | ||
| status = %i[ok queued error warn running].select { |s| opts[s] } |
Member
Author
There was a problem hiding this comment.
.compact only removes nil, but opts stores the checkbox as a boolean, so false entries dont get removed.
ohhAndy
commented
Oct 8, 2026
| ...taskStatus, | ||
| ], | ||
| ); | ||
| if (Array.isArray(taskStatus) && taskStatus.length > 0) { |
Member
Author
There was a problem hiding this comment.
empty array could pass the check, so this is just an extra guardrail
ohhAndy
commented
Oct 8, 2026
| when "tasks_1" then @layout = "my_tasks" | ||
| when "tasks_2", "alltasks_2" then @layout = "all_tasks" | ||
| end | ||
| tasks_set_default_options |
Member
Author
There was a problem hiding this comment.
build_jobs_tab already calls this, so this could reset/override presets and is redundant
Member
|
Checked commit ohhAndy@5a612f8 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9471
Depends on: ManageIQ/manageiq#24004
Fixes several bugs in the Tasks UI that have been present since the named scope filter path was introduced in #2585 . Filters for zone, user, status, and My Tasks were either silently ignored or producing incorrect results.
My Tasks (Should only show user's tasks) (60 vs 15 tasks)
Before:
After:
All Tasks (Zone Filter) (490 vs 20)
Before:
After:
All Tasks (User Filter) (490 vs 15)
Before:
After:
All Tasks (Time Period Filter) (490 vs 60)
Before:
After:
All Tasks (Checkboxes) (Only Ok unchecked) (376 vs 48)
Before:
After:
@miq-bot assign @GilbertCherrie
@miq-bot add-label bug
@miq-bot add-reviewer @GilbertCherrie