Repository navigation
Reorganize the files for the standalone worker and remove inline gemfile - #575
Merged
Merged
Conversation
ohhAndy
force-pushed
the
move-event-parser-to-lib
branch
from
September 29, 2026 19:46
ea3711e to
a186c95
Compare
Fryguy
reviewed
Sep 29, 2026
Fryguy
reviewed
Sep 29, 2026
Fryguy
reviewed
Sep 29, 2026
ohhAndy
force-pushed
the
move-event-parser-to-lib
branch
from
September 29, 2026 19:57
a186c95 to
a7d9078
Compare
agrare
reviewed
Oct 1, 2026
ohhAndy
force-pushed
the
move-event-parser-to-lib
branch
from
October 1, 2026 14:15
a7d9078 to
1db10a2
Compare
ohhAndy
force-pushed
the
move-event-parser-to-lib
branch
from
October 1, 2026 14:17
1db10a2 to
1a5c670
Compare
ohhAndy
changed the title
ohhAndy
force-pushed
the
move-event-parser-to-lib
branch
from
October 1, 2026 16:28
87e1c57 to
a780e27
Compare
agrare
reviewed
Oct 6, 2026
agrare
reviewed
Oct 6, 2026
… load path, and add bundler setup to worker script
Member
|
Checked commits ohhAndy/manageiq-providers-kubernetes@537c9e2~...ace07f9 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 |
ohhAndy
commented
Oct 6, 2026
| #!/usr/bin/env ruby | ||
|
|
||
| ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../../../Gemfile', __dir__) | ||
| require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE']) |
agrare
reviewed
Oct 6, 2026
| @@ -0,0 +1,41 @@ | |||
| #!/usr/bin/env ruby | |||
|
|
|||
| ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../../../Gemfile', __dir__) | |||
Member
There was a problem hiding this comment.
I was thinking this ManageIQ/manageiq#24001
But this is a good solution also especially since it would allow core to override it.
Member
There was a problem hiding this comment.
Oh I like this - when we're running from the plugin then it gives you that flexibility.
agrare
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #569
@miq-bot assign @Fryguy
@miq-bot add-label refactor