Skip to content

Support running ContainerManager EventCatcher as a non-Rails worker - #585

Merged
agrare merged 3 commits into
ManageIQ:masterfrom
ohhAndy:support-non-rails-container-event-catcher
Oct 9, 2026
Merged

agrare merged 3 commits into
ManageIQ:masterfrom
ohhAndy:support-non-rails-container-event-catcher

Conversation

@ohhAndy

@ohhAndy ohhAndy commented Sep 21, 2026

Copy link
Copy Markdown
Member

Highlight: ~300MB -> ~89MB (~70% lower)

Part of ManageIQ/manageiq#22955

Depends on:

@miq-bot assign @agrare
@miq-bot add-label enhancement

@miq-bot miq-bot added the enhancement New feature or request label Sep 21, 2026
@ohhAndy
ohhAndy force-pushed the support-non-rails-container-event-catcher branch 2 times, most recently from 43c8624 to c6a2461 Compare September 25, 2026 19:59
@ohhAndy ohhAndy changed the title [WIP] Support running ContainerManager EventCatcher as a non-Rails worker Support running ContainerManager EventCatcher as a non-Rails worker Sep 25, 2026
Comment thread workers/container_event_catcher/worker Outdated
Comment thread workers/container_event_catcher/worker Outdated
Comment thread lib/tasks_private/release.rake Outdated
Comment thread lib/tasks_private/release.rake Outdated
@agrare

agrare commented Sep 28, 2026

Copy link
Copy Markdown
Member

@Fryguy can you review as well? This will be the basis for the other "subclassed" container providers so want to try get the pattern nailed down.

@ohhAndy
ohhAndy force-pushed the support-non-rails-container-event-catcher branch from 459cb33 to 60b45c4 Compare September 29, 2026 15:42
@Fryguy

Fryguy commented Sep 29, 2026

Copy link
Copy Markdown
Member

Ugh just realized that while I mentioned the rake release stuff, it was never intended for git repositories, and while the PR here will likely work, it won't work on our downstream overrides - Need to think this through or we need to come up with a different way to do this.

Comment thread spec/workers/container_event_catcher/event_catcher_spec.rb Outdated
Comment thread spec/workers/container_event_catcher/worker_gemfile_sync_spec.rb Outdated
Comment thread workers/container_event_catcher/event_catcher.rb Outdated
@ohhAndy
ohhAndy force-pushed the support-non-rails-container-event-catcher branch 2 times, most recently from ad9edbf to a2f5208 Compare September 29, 2026 19:54
Comment thread workers/container_event_catcher/event_catcher.rb Outdated
@ohhAndy
ohhAndy force-pushed the support-non-rails-container-event-catcher branch from a2f5208 to 4362e70 Compare September 30, 2026 16:55
@miq-bot

miq-bot commented Sep 30, 2026

Copy link
Copy Markdown
Member

Some comments on commits ohhAndy/manageiq-providers-ibm_cloud@44c3793~...4362e70

lib/tasks_private/release.rake

  • ⚠️ - 47 - Detected puts. Remove all debugging statements.
  • ⚠️ - 48 - Detected puts. Remove all debugging statements.
  • ⚠️ - 49 - Detected puts. Remove all debugging statements.
  • ⚠️ - 50 - Detected puts. Remove all debugging statements.
  • ⚠️ - 51 - Detected puts. Remove all debugging statements.
  • ⚠️ - 52 - Detected puts. Remove all debugging statements.
  • ⚠️ - 87 - Detected puts. Remove all debugging statements.
  • ⚠️ - 94 - Detected puts. Remove all debugging statements.
  • ⚠️ - 95 - Detected puts. Remove all debugging statements.
  • ⚠️ - 96 - Detected puts. Remove all debugging statements.
  • ⚠️ - 97 - Detected puts. Remove all debugging statements.
  • ⚠️ - 98 - Detected puts. Remove all debugging statements.
  • ⚠️ - 99 - Detected puts. Remove all debugging statements.

1 similar comment
@miq-bot

miq-bot commented Sep 30, 2026

Copy link
Copy Markdown
Member

Some comments on commits ohhAndy/manageiq-providers-ibm_cloud@44c3793~...4362e70

lib/tasks_private/release.rake

  • ⚠️ - 47 - Detected puts. Remove all debugging statements.
  • ⚠️ - 48 - Detected puts. Remove all debugging statements.
  • ⚠️ - 49 - Detected puts. Remove all debugging statements.
  • ⚠️ - 50 - Detected puts. Remove all debugging statements.
  • ⚠️ - 51 - Detected puts. Remove all debugging statements.
  • ⚠️ - 52 - Detected puts. Remove all debugging statements.
  • ⚠️ - 87 - Detected puts. Remove all debugging statements.
  • ⚠️ - 94 - Detected puts. Remove all debugging statements.
  • ⚠️ - 95 - Detected puts. Remove all debugging statements.
  • ⚠️ - 96 - Detected puts. Remove all debugging statements.
  • ⚠️ - 97 - Detected puts. Remove all debugging statements.
  • ⚠️ - 98 - Detected puts. Remove all debugging statements.
  • ⚠️ - 99 - Detected puts. Remove all debugging statements.

@miq-bot

miq-bot commented Sep 30, 2026

Copy link
Copy Markdown
Member

Checked commits ohhAndy/manageiq-providers-ibm_cloud@44c3793~...4362e70 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1
5 files checked, 0 offenses detected
Everything looks fine. 👍

@ohhAndy
ohhAndy force-pushed the support-non-rails-container-event-catcher branch from 4362e70 to 48c7edf Compare October 7, 2026 14:44
@agrare
agrare merged commit ef39529 into ManageIQ:master Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants