Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions Casks/j/jprofiler.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
cask "jprofiler" do
version "16.0"
sha256 "1504b089704961b242ff7f13045f51f1530b39c5fea3e880ba278709ba7998ef"

url "https://download-gcdn.ej-technologies.com/jprofiler/jprofiler_macos_#{version.dots_to_underscores}.dmg"
on_macos do
sha256 "1504b089704961b242ff7f13045f51f1530b39c5fea3e880ba278709ba7998ef"

url "https://download-gcdn.ej-technologies.com/jprofiler/jprofiler_macos_#{version.dots_to_underscores}.dmg"
end

on_linux do
sha256 "c7ff6d6130b36f360e953f88c45c447400e3ca984b05d72d0db9811566a478c0"

url "https://download-gcdn.ej-technologies.com/jprofiler/jprofiler_linux-x64_#{version.dots_to_underscores}.tar.gz"
end

name "JProfiler"
desc "Java profiler"
homepage "https://www.ej-technologies.com/jprofiler"
Expand All @@ -20,14 +30,24 @@
end
end

depends_on macos: ">= :big_sur"
on_macos do
depends_on macos: ">= :big_sur"

app "JProfiler.app"
app "JProfiler.app"

zap trash: [
"~/.jprofiler*",
"~/Library/Preferences/com.jprofiler.history.plist",
"~/Library/Preferences/com.jprofiler.v*.plist",
"~/Library/Preferences/jprofiler.vmoptions",
]
zap trash: [
"~/.jprofiler*",
"~/Library/Preferences/com.jprofiler.history.plist",
"~/Library/Preferences/com.jprofiler.v*.plist",
"~/Library/Preferences/jprofiler.vmoptions",
]
end

on_linux do
depends_on arch: :x86_64

binary "jprofiler#{version}/bin/jprofiler"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same tool that is installed on macOS or it solely a cli tool?
The question is really whether this is the same thing or if it should be jprofiler-cli as a separate cask. Is the binary version available on macOS also?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same UI tool

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they only list the dmg for OSX (which i have zero experience with). windows has both an exe installer and a zip file, and for linux the suport a deb, rpm, and tar.gz file

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are technically java apps on every platform, so in theory this could run on arm as well, but i have no way of testing that to verify

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that being said, this change uses the version that has the JRE built into it that way i didn't have to track what JRE it wants to run on and depend on that in this file. to support arm we'd have to change this to download the non-jre version and make sure to figure out what version it wants/needs and depend on that as well


zap trash: "~/.jprofiler*"
end
end
Loading