Update jprofiler to install on linux#255924
Update jprofiler to install on linux#255924nivekastoreth wants to merge 1 commit intoHomebrew:mainfrom
Conversation
| on_linux do | ||
| depends_on arch: :x86_64 | ||
|
|
||
| binary "jprofiler#{version}/bin/jprofiler" |
There was a problem hiding this comment.
Is this the same tool that is installed on macOS or it solely a cli tool?
The question is really whether this is the same thing or if it should be jprofiler-cli as a separate cask. Is the binary version available on macOS also?
There was a problem hiding this comment.
they only list the dmg for OSX (which i have zero experience with). windows has both an exe installer and a zip file, and for linux the suport a deb, rpm, and tar.gz file
There was a problem hiding this comment.
There was a problem hiding this comment.
they are technically java apps on every platform, so in theory this could run on arm as well, but i have no way of testing that to verify
There was a problem hiding this comment.
that being said, this change uses the version that has the JRE built into it that way i didn't have to track what JRE it wants to run on and depend on that in this file. to support arm we'd have to change this to download the non-jre version and make sure to figure out what version it wants/needs and depend on that as well
2 participants
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.