Repository navigation
Conversation
Jakfut
added
Bug Fix
Contributor
|
This might be an FML bug worth fixing via mixin in Hodgepodge, rather than just for GregTech. |
Nikolay-Sitnikov
requested changes
Oct 28, 2026
Nikolay-Sitnikov
left a comment
Nikolay-Sitnikov
left a comment
Contributor
There was a problem hiding this comment.
Also, you are not using the PR template which all of our PRs are required to use. When you remake this PR in Hodgepodge (or keep it here, if there's a good reason to do so), make sure to use the PR template, read the AI Policy, and check the appropriate boxes.
2 of 4 tasks
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GregTech's network channels passed their Netty buffer to FML's
FMLProxyPacketuntrimmed, and FML sends the buffer's whole backing array, not just the written bytes. So every packet was padded with zeros up to its buffer's capacity: the next power of two, at least 256 bytes.The channels now hand FML only the written bytes, as FML's own network wrapper does.
Packet readers are unchanged and never read the padding, so old and new clients and servers stay compatible.
In my tests on a UHV world base, this cut GregTech's network traffic by 50%