Repository navigation
Send only the written bytes of each network packet - #155
Merged
RecursivePineapple merged 2 commits intoOct 31, 2026
Merged
Conversation
Nikolay-Sitnikov
previously requested changes
Oct 28, 2026
Nikolay-Sitnikov
left a comment
Nikolay-Sitnikov
left a comment
There was a problem hiding this comment.
As mentioned in GTNewHorizons/GT5-Unofficial#8596:
You are not using the PR template which all of our PRs are required to use. When you remake this PR in Hodgepodge (or keep it here, if there's a good reason to do so), make sure to use the PR template, read the AI Policy, and check the appropriate boxes.
2 of 4 tasks
Contributor
Author
|
I agree that its not worth it to fix the 15 or so other mods which have this bug one by one, but this should still be fixed in CC, because by far the most traffic comes from CC, and Hodgepodge can't fix all of it, column packets also store the padded array as their column data, inside the packet, so with only the Hodgepodge fix they're still about 30% zeros. |
Contributor
Author
Checklist
|
RecursivePineapple
approved these changes
Oct 31, 2026
RecursivePineapple
dismissed
Nikolay-Sitnikov’s stale review
October 31, 2026 22:38
Template checkboxes were added in a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network channel now hands FML only the written bytes, as FML's own network wrapper does. Column data also had the zero padding a second time, inside the packet.